-
Notifications
You must be signed in to change notification settings - Fork 945
Define internal password policy typings #7446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define internal password policy typings #7446
Conversation
|
* Validates the password against the policy. | ||
* @param password Password to validate. | ||
*/ | ||
validatePassword(password: string): PasswordValidationStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be 2 private helper methods (_checkLengthOptions
and _checkCharacterOptions
) defined in PasswordPolicyImpl
which will implement this interface. The validatePassword
method will call these helpers internally. I did not include this class in this PR to make this easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add public static annotation?
Size Report 1Affected ProductsNo changes between base commit (3a7c4a3) and merge commit (3534060).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (3a7c4a3) and merge commit (3534060).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Validates the password against the policy. | ||
* @param password Password to validate. | ||
*/ | ||
validatePassword(password: string): PasswordValidationStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add public static annotation?
|
* Define internal password policy typings
Define internal password policy typings for use in password validation. These types will allow us to split up validating different requirements into separate helper methods and construct the validation status as each of these requirements are validated.