Skip to content

Define implementation of internal password policy class #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 12, 2023
Merged

Define implementation of internal password policy class #7447

merged 8 commits into from
Jul 12, 2023

Conversation

ch5zzy
Copy link
Contributor

@ch5zzy ch5zzy commented Jul 11, 2023 •
edited
Loading

Define PasswordPolicyImpl for use in password validation. Also, fix typing for GetPasswordPolicyResponse to match the backend response.

@ch5zzy
* Define PasswordPolicyImpl
e482874 
* Define PasswordValidationStatusImpl

* Fix password policy response typing
@ch5zzy ch5zzy requested a review from Xiaoshouzi-gh July 11, 2023 23:59
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f0acf72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (e40b1e7) and merge commit (50b9288).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m5y4Hc61c7.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (e40b1e7) and merge commit (50b9288).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7DJWPObgzI.html

@ch5zzy ch5zzy changed the title Define implementations of internal password policy classes Define implementations of internal password policy class Jul 12, 2023
@ch5zzy ch5zzy changed the title Define implementations of internal password policy class Define implementation of internal password policy class Jul 12, 2023
ch5zzy
ch5zzy commented Jul 12, 2023
View reviewed changes
@ch5zzy ch5zzy marked this pull request as ready for review July 12, 2023 17:49
renkelvin
renkelvin reviewed Jul 12, 2023
View reviewed changes
Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jul 12, 2023
View reviewed changes
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch5zzy ch5zzy merged commit ca662bd into password-policy Jul 12, 2023
@ch5zzy ch5zzy deleted the use-password-policy-internal-typings branch July 12, 2023 20:58
ch5zzy added a commit that referenced this pull request Jul 13, 2023
@ch5zzy
Define implementation of internal password policy class (#7447)
525c2ab 
* Define PasswordPolicyImpl

* Add PasswordPolicyCustomStrengthOptions internal typing
@firebase firebase locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin left review comments

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@markarndt markarndt Awaiting requested review from markarndt

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

@lisajian lisajian Awaiting requested review from lisajian

@prameshj prameshj Awaiting requested review from prameshj

@sam-gc sam-gc Awaiting requested review from sam-gc

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ch5zzy @google-oss-bot @renkelvin @Xiaoshouzi-gh