Skip to content

Update auth demo to include password validation #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

ch5zzy
Copy link
Contributor

@ch5zzy ch5zzy commented Jul 17, 2023

Update the auth demo to include a section for password validation. As a password is typed in, the status of requirements will be displayed and updated based on what is required by the policy.

See a quick demo at https://drive.google.com/file/d/1WlAkDJrZCS5qiMYSrNLk-LDWjquFPxTA/view?usp=sharing

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 221ee6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2023

@ch5zzy ch5zzy marked this pull request as ready for review July 18, 2023 16:49
@ch5zzy ch5zzy requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 18, 2023 16:49
@ch5zzy ch5zzy requested a review from Xiaoshouzi-gh July 18, 2023 16:49
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be separate PRs to add the password policy check on existing sign in, sign up & reset password flow?

@ch5zzy
Copy link
Contributor Author

ch5zzy commented Jul 18, 2023

Will there be separate PRs to add the password policy check on existing sign in, sign up & reset password flow?

Since password validation is not being implemented as part of these flows, I figured it was best to have a separate section for testing password validation. We could have a button toggle for each of these flows (like enable/disable password validation) with a similar UI to this for displaying the requirements, but I wasn't sure if we wanted to duplicate this UI across these sections or just have one section for demoing password validation.

I will add displaying the forceUpgradeOnSignin to the sign-in flow in another PR.

@ch5zzy ch5zzy requested a review from Xiaoshouzi-gh July 18, 2023 23:23
@ch5zzy ch5zzy merged commit a70a9ac into password-policy Jul 18, 2023
@ch5zzy ch5zzy deleted the update-auth-demo-password-validation branch July 18, 2023 23:45
@firebase firebase locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants