Fix bug when non-alphanumeric characters is undefined #7485

ch5zzy · 2023-07-20T23:28:56Z

The non-alphanumeric characters could be undefined when returned from the backend, even though they are not marked as optional. In this case, the SDK will store and return an empty string as part of the policy.

…in the password policy response

changeset-bot · 2023-07-20T23:28:59Z

⚠️ No Changeset found

Latest commit: f97c964

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/auth/src/core/auth/password_policy_impl.ts

google-oss-bot · 2023-07-20T23:48:58Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`defdb66`)	Merge (`f7ea9d7`)	Diff
browser	176 kB	176 kB	+72 B (+0.0%)
cordova	205 kB	205 kB	+72 B (+0.0%)
esm5	230 kB	230 kB	+72 B (+0.0%)
main	175 kB	175 kB	+72 B (+0.0%)
module	176 kB	176 kB	+72 B (+0.0%)
react-native	190 kB	190 kB	+72 B (+0.0%)

@firebase/auth/cordova
Type Base (defdb66) Merge (f7ea9d7) Diff
browser 205 kB 205 kB +72 B (+0.0%)
module 205 kB 205 kB +72 B (+0.0%)
@firebase/auth/internal
Type Base (defdb66) Merge (f7ea9d7) Diff
browser 187 kB 187 kB +72 B (+0.0%)
esm5 244 kB 244 kB +72 B (+0.0%)
main 211 kB 211 kB +72 B (+0.0%)
module 187 kB 187 kB +72 B (+0.0%)
@firebase/auth/react-native
Type Base (defdb66) Merge (f7ea9d7) Diff
browser 190 kB 190 kB +72 B (+0.0%)
module 190 kB 190 kB +72 B (+0.0%)

`bundle`

Type	Base (`defdb66`)	Merge (`f7ea9d7`)	Diff
auth (Anonymous)	74.9 kB	74.9 kB	+64 B (+0.1%)
auth (EmailAndPassword)	80.0 kB	80.1 kB	+64 B (+0.1%)
auth (GoogleFBTwitterGitHubPopup)	101 kB	101 kB	+64 B (+0.1%)
auth (GooglePopup)	98.3 kB	98.4 kB	+64 B (+0.1%)
auth (GoogleRedirect)	98.6 kB	98.6 kB	+64 B (+0.1%)
auth (Phone)	84.7 kB	84.8 kB	+64 B (+0.1%)

`firebase`

Type	Base (`defdb66`)	Merge (`f7ea9d7`)	Diff
firebase-auth-compat.js	136 kB	136 kB	+60 B (+0.0%)
firebase-auth-cordova.js	152 kB	153 kB	+64 B (+0.0%)
firebase-auth-react-native.js	165 kB	165 kB	+64 B (+0.0%)
firebase-auth.js	131 kB	131 kB	+64 B (+0.0%)
firebase-compat.js	777 kB	777 kB	+60 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/A5O6VCdOwM.html

google-oss-bot · 2023-07-21T00:07:33Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.0 kB 39.1 kB +64 B (+0.2%)
  size-with-ext-deps 59.8 kB 59.9 kB +64 B (+0.1%)
- ActionCodeURL
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.9 kB 40.0 kB +64 B (+0.2%)
  size-with-ext-deps 60.9 kB 61.0 kB +64 B (+0.1%)
- AuthCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.1 kB +64 B (+0.2%)
  size-with-ext-deps 59.8 kB 59.9 kB +64 B (+0.1%)
- AuthErrorCodes
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 43.9 kB +64 B (+0.1%)
  size-with-ext-deps 64.7 kB 64.7 kB +64 B (+0.1%)
- EmailAuthCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 41.7 kB 41.8 kB +64 B (+0.2%)
  size-with-ext-deps 62.5 kB 62.6 kB +64 B (+0.1%)
- EmailAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.1 kB 43.2 kB +64 B (+0.1%)
  size-with-ext-deps 64.2 kB 64.2 kB +64 B (+0.1%)
- FacebookAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 43.9 kB +64 B (+0.1%)
  size-with-ext-deps 64.6 kB 64.7 kB +64 B (+0.1%)
- FactorId
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- GithubAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 43.9 kB +64 B (+0.1%)
  size-with-ext-deps 64.6 kB 64.7 kB +64 B (+0.1%)
- GoogleAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 43.9 kB +64 B (+0.1%)
  size-with-ext-deps 64.6 kB 64.7 kB +64 B (+0.1%)
- OAuthCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 41.0 kB 41.0 kB +64 B (+0.2%)
  size-with-ext-deps 61.7 kB 61.8 kB +64 B (+0.1%)
- OAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 44.8 kB 44.9 kB +64 B (+0.1%)
  size-with-ext-deps 65.6 kB 65.6 kB +64 B (+0.1%)
- OperationType
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- PhoneAuthCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.9 kB 41.0 kB +64 B (+0.2%)
  size-with-ext-deps 61.7 kB 61.8 kB +64 B (+0.1%)
- PhoneAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 42.6 kB 42.7 kB +64 B (+0.2%)
  size-with-ext-deps 63.4 kB 63.5 kB +64 B (+0.1%)
- PhoneMultiFactorGenerator
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.7 kB 39.7 kB +64 B (+0.2%)
  size-with-ext-deps 60.5 kB 60.5 kB +64 B (+0.1%)
- ProviderId
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 39.0 kB +64 B (+0.2%)
  size-with-ext-deps 59.7 kB 59.8 kB +64 B (+0.1%)
- RecaptchaVerifier
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 45.0 kB 45.1 kB +64 B (+0.1%)
  size-with-ext-deps 65.8 kB 65.9 kB +64 B (+0.1%)
- SAMLAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 45.1 kB 45.2 kB +64 B (+0.1%)
  size-with-ext-deps 65.9 kB 66.0 kB +64 B (+0.1%)
- SignInMethod
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.0 kB 39.0 kB +64 B (+0.2%)
  size-with-ext-deps 59.7 kB 59.8 kB +64 B (+0.1%)
- TotpMultiFactorGenerator
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 41.3 kB 41.4 kB +64 B (+0.2%)
  size-with-ext-deps 62.1 kB 62.2 kB +64 B (+0.1%)
- TotpSecret
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.8 kB 39.8 kB +64 B (+0.2%)
  size-with-ext-deps 60.6 kB 60.6 kB +64 B (+0.1%)
- TwitterAuthProvider
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 43.9 kB +64 B (+0.1%)
  size-with-ext-deps 64.6 kB 64.7 kB +64 B (+0.1%)
- applyActionCode
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 39.0 kB +64 B (+0.2%)
  size-with-ext-deps 59.7 kB 59.8 kB +64 B (+0.1%)
- beforeAuthStateChanged
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- browserLocalPersistence
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 42.2 kB 42.3 kB +64 B (+0.2%)
  size-with-ext-deps 63.1 kB 63.2 kB +64 B (+0.1%)
- browserPopupRedirectResolver
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 62.9 kB 62.9 kB +64 B (+0.1%)
  size-with-ext-deps 83.9 kB 83.9 kB +64 B (+0.1%)
- browserSessionPersistence
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 42.2 kB 42.3 kB +64 B (+0.2%)
  size-with-ext-deps 63.1 kB 63.2 kB +64 B (+0.1%)
- checkActionCode
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.0 kB 40.1 kB +64 B (+0.2%)
  size-with-ext-deps 60.8 kB 60.9 kB +64 B (+0.1%)
- confirmPasswordReset
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.2 kB +64 B (+0.2%)
  size-with-ext-deps 59.9 kB 60.0 kB +64 B (+0.1%)
- connectAuthEmulator
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.5 kB 40.6 kB +64 B (+0.2%)
  size-with-ext-deps 61.3 kB 61.4 kB +64 B (+0.1%)
- createUserWithEmailAndPassword
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.8 kB 40.9 kB +64 B (+0.2%)
  size-with-ext-deps 61.6 kB 61.7 kB +64 B (+0.1%)
- debugErrorMap
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 51.0 kB 51.1 kB +64 B (+0.1%)
  size-with-ext-deps 71.8 kB 71.9 kB +64 B (+0.1%)
- deleteUser
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- fetchSignInMethodsForEmail
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.2 kB +64 B (+0.2%)
  size-with-ext-deps 59.9 kB 60.0 kB +64 B (+0.1%)
- getAdditionalUserInfo
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.1 kB 40.2 kB +64 B (+0.2%)
  size-with-ext-deps 60.9 kB 61.0 kB +64 B (+0.1%)
- getAuth
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 72.9 kB 73.0 kB +64 B (+0.1%)
  size-with-ext-deps 100 kB 100 kB +64 B (+0.1%)
- getIdToken
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- getIdTokenResult
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.6 kB +64 B (+0.1%)
- getMultiFactorResolver
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 41.7 kB 41.8 kB +64 B (+0.2%)
  size-with-ext-deps 62.5 kB 62.6 kB +64 B (+0.1%)
- getRedirectResult
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 46.3 kB 46.4 kB +64 B (+0.1%)
  size-with-ext-deps 67.1 kB 67.2 kB +64 B (+0.1%)
- inMemoryPersistence
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.6 kB +64 B (+0.1%)
- indexedDBLocalPersistence
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 46.2 kB 46.3 kB +64 B (+0.1%)
  size-with-ext-deps 67.0 kB 67.1 kB +64 B (+0.1%)
- initializeAuth
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.1 kB +64 B (+0.2%)
  size-with-ext-deps 60.3 kB 60.4 kB +64 B (+0.1%)
- initializeRecaptchaConfig
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.7 kB 59.7 kB +64 B (+0.1%)
- isSignInWithEmailLink
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.0 kB 40.1 kB +64 B (+0.2%)
  size-with-ext-deps 61.0 kB 61.1 kB +64 B (+0.1%)
- linkWithCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.8 kB 39.9 kB +64 B (+0.2%)
  size-with-ext-deps 60.6 kB 60.7 kB +64 B (+0.1%)
- linkWithPhoneNumber
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.4 kB 43.5 kB +64 B (+0.1%)
  size-with-ext-deps 64.2 kB 64.3 kB +64 B (+0.1%)
- linkWithPopup
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 49.9 kB 50.0 kB +64 B (+0.1%)
  size-with-ext-deps 70.7 kB 70.8 kB +64 B (+0.1%)
- linkWithRedirect
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 45.2 kB 45.2 kB +64 B (+0.1%)
  size-with-ext-deps 65.9 kB 66.0 kB +64 B (+0.1%)
- multiFactor
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 41.0 kB 41.1 kB +64 B (+0.2%)
  size-with-ext-deps 61.8 kB 61.9 kB +64 B (+0.1%)
- onAuthStateChanged
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- onIdTokenChanged
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- parseActionCodeURL
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.9 kB 40.0 kB +64 B (+0.2%)
  size-with-ext-deps 61.0 kB 61.0 kB +64 B (+0.1%)
- prodErrorMap
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.6 kB +64 B (+0.1%)
- reauthenticateWithCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.4 kB 40.5 kB +64 B (+0.2%)
  size-with-ext-deps 61.2 kB 61.3 kB +64 B (+0.1%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.9 kB 44.0 kB +64 B (+0.1%)
  size-with-ext-deps 64.7 kB 64.8 kB +64 B (+0.1%)
- reauthenticateWithPopup
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 49.9 kB 50.0 kB +64 B (+0.1%)
  size-with-ext-deps 70.7 kB 70.8 kB +64 B (+0.1%)
- reauthenticateWithRedirect
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 44.9 kB 45.0 kB +64 B (+0.1%)
  size-with-ext-deps 65.7 kB 65.8 kB +64 B (+0.1%)
- reload
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.6 kB +64 B (+0.1%)
- sendEmailVerification
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.7 kB 39.8 kB +64 B (+0.2%)
  size-with-ext-deps 60.5 kB 60.6 kB +64 B (+0.1%)
- sendPasswordResetEmail
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.5 kB 40.6 kB +64 B (+0.2%)
  size-with-ext-deps 61.3 kB 61.4 kB +64 B (+0.1%)
- sendSignInLinkToEmail
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.5 kB 40.6 kB +64 B (+0.2%)
  size-with-ext-deps 61.3 kB 61.4 kB +64 B (+0.1%)
- setPersistence
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- signInAnonymously
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.0 kB 40.0 kB +64 B (+0.2%)
  size-with-ext-deps 60.8 kB 60.8 kB +64 B (+0.1%)
- signInWithCredential
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.2 kB 40.3 kB +64 B (+0.2%)
  size-with-ext-deps 61.0 kB 61.0 kB +64 B (+0.1%)
- signInWithCustomToken
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.8 kB 39.9 kB +64 B (+0.2%)
  size-with-ext-deps 60.6 kB 60.7 kB +64 B (+0.1%)
- signInWithEmailAndPassword
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 44.8 kB 44.9 kB +64 B (+0.1%)
  size-with-ext-deps 65.8 kB 65.9 kB +64 B (+0.1%)
- signInWithEmailLink
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 44.8 kB 44.9 kB +64 B (+0.1%)
  size-with-ext-deps 65.8 kB 65.9 kB +64 B (+0.1%)
- signInWithPhoneNumber
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 43.7 kB 43.8 kB +64 B (+0.1%)
  size-with-ext-deps 64.5 kB 64.6 kB +64 B (+0.1%)
- signInWithPopup
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 49.9 kB 50.0 kB +64 B (+0.1%)
  size-with-ext-deps 70.7 kB 70.8 kB +64 B (+0.1%)
- signInWithRedirect
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 44.6 kB 44.7 kB +64 B (+0.1%)
  size-with-ext-deps 65.4 kB 65.5 kB +64 B (+0.1%)
- signOut
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- unlink
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.4 kB 39.5 kB +64 B (+0.2%)
  size-with-ext-deps 60.2 kB 60.2 kB +64 B (+0.1%)
- updateCurrentUser
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- updateEmail
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.2 kB +64 B (+0.2%)
  size-with-ext-deps 59.9 kB 60.0 kB +64 B (+0.1%)
- updatePassword
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.1 kB 39.2 kB +64 B (+0.2%)
  size-with-ext-deps 59.9 kB 60.0 kB +64 B (+0.1%)
- updatePhoneNumber
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.6 kB 39.6 kB +64 B (+0.2%)
  size-with-ext-deps 60.3 kB 60.4 kB +64 B (+0.1%)
- updateProfile
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.3 kB 39.4 kB +64 B (+0.2%)
  size-with-ext-deps 60.1 kB 60.2 kB +64 B (+0.1%)
- useDeviceLanguage
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.8 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- validatePassword
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 38.9 kB 38.9 kB +64 B (+0.2%)
  size-with-ext-deps 59.6 kB 59.7 kB +64 B (+0.1%)
- verifyBeforeUpdateEmail
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 39.8 kB 39.8 kB +64 B (+0.2%)
  size-with-ext-deps 60.5 kB 60.6 kB +64 B (+0.1%)
- verifyPasswordResetCode
  Size
  Type Base (defdb66) Merge (f7ea9d7) Diff
  size 40.1 kB 40.2 kB +64 B (+0.2%)
  size-with-ext-deps 60.9 kB 61.0 kB +64 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/RRERSBcEIe.html

Store an empty string if no non-alphanumeric characters are included …

f97c964

…in the password policy response

ch5zzy requested a review from Xiaoshouzi-gh July 20, 2023 23:29

ch5zzy marked this pull request as ready for review July 20, 2023 23:29

ch5zzy requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 20, 2023 23:29

ch5zzy commented Jul 20, 2023

View reviewed changes

packages/auth/src/core/auth/password_policy_impl.ts Show resolved Hide resolved

Xiaoshouzi-gh approved these changes Jul 20, 2023

View reviewed changes

ch5zzy merged commit 2f51103 into password-policy Jul 20, 2023

ch5zzy deleted the fix-allowed-non-alphanumeric-chars branch July 20, 2023 23:40

firebase locked and limited conversation to collaborators Aug 20, 2023

Fix bug when non-alphanumeric characters is undefined #7485

Fix bug when non-alphanumeric characters is undefined #7485

Uh oh!

Conversation

ch5zzy commented Jul 20, 2023

Uh oh!

changeset-bot bot commented Jul 20, 2023

⚠️ No Changeset found

Uh oh!

Uh oh!

google-oss-bot commented Jul 20, 2023

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 21, 2023

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TotpMultiFactorGenerator

TotpSecret

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

initializeRecaptchaConfig

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

prodErrorMap

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TotpMultiFactorGenerator`

`TotpSecret`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`initializeRecaptchaConfig`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`