Skip to content

Add password policy integration tests #7489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 1, 2023

Conversation

ch5zzy
Copy link
Contributor

@ch5zzy ch5zzy commented Jul 21, 2023

Add integration tests for password policy / password validation. Update other tests to use passwords that are valid against the policy configured for the project so they don't fail due to not meeting the password requirements.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: 3213a28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (2f51103)Merge (ad8559d)Diff
    browser176 kB176 kB+57 B (+0.0%)
    cordova205 kB205 kB+55 B (+0.0%)
    esm5230 kB230 kB+55 B (+0.0%)
    main175 kB175 kB+55 B (+0.0%)
    module176 kB176 kB+57 B (+0.0%)
    react-native190 kB190 kB+55 B (+0.0%)
  • @firebase/auth/cordova

    TypeBase (2f51103)Merge (ad8559d)Diff
    browser205 kB205 kB+55 B (+0.0%)
    module205 kB205 kB+55 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (2f51103)Merge (ad8559d)Diff
    browser187 kB187 kB+57 B (+0.0%)
    esm5244 kB244 kB+55 B (+0.0%)
    main211 kB211 kB+55 B (+0.0%)
    module187 kB187 kB+57 B (+0.0%)
  • @firebase/auth/react-native

    TypeBase (2f51103)Merge (ad8559d)Diff
    browser190 kB190 kB+55 B (+0.0%)
    module190 kB190 kB+55 B (+0.0%)
  • bundle

    TypeBase (2f51103)Merge (ad8559d)Diff
    auth (Anonymous)74.9 kB74.9 kB+17 B (+0.0%)
    auth (EmailAndPassword)80.1 kB80.1 kB+17 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)101 kB101 kB+17 B (+0.0%)
    auth (GooglePopup)98.4 kB98.4 kB+17 B (+0.0%)
    auth (GoogleRedirect)98.6 kB98.7 kB+17 B (+0.0%)
    auth (Phone)84.8 kB84.8 kB+17 B (+0.0%)
  • firebase

    TypeBase (2f51103)Merge (ad8559d)Diff
    firebase-auth-compat.js136 kB136 kB+6 B (+0.0%)
    firebase-auth-cordova.js153 kB153 kB+6 B (+0.0%)
    firebase-auth-react-native.js165 kB165 kB+6 B (+0.0%)
    firebase-auth.js131 kB131 kB+6 B (+0.0%)
    firebase-compat.js777 kB777 kB+6 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ovW04MlwUR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 22, 2023

Size Analysis Report 1

This report is too large (139,506 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wTX1eDsgj0.html

@ch5zzy ch5zzy requested a review from Xiaoshouzi-gh July 26, 2023 21:31
@ch5zzy ch5zzy marked this pull request as ready for review July 27, 2023 17:10
@ch5zzy ch5zzy requested review from lisajian, prameshj, renkelvin, sam-gc and a team as code owners July 27, 2023 17:10
@ch5zzy
Copy link
Contributor Author

ch5zzy commented Jul 27, 2023

A new tenant passpol-tenant was added to the test project to allow us to test validatePassword using the production backend. The Auth emulator does not currently support the /v2/passwordPolicy endpoint, but testing against the production backend is useful since we would want to update this code if something on the backend changes.

@ch5zzy ch5zzy requested a review from prameshj July 31, 2023 17:05
@ch5zzy ch5zzy merged commit 642259b into password-policy Aug 1, 2023
@ch5zzy ch5zzy deleted the password-policy-integration-tests branch August 1, 2023 18:17
@firebase firebase locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants