Skip to content

Export internal interface PrivateSettings for console #7492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2023
Merged

Export internal interface PrivateSettings for console #7492

merged 4 commits into from
Aug 1, 2023

Conversation

qtz1
Copy link
Contributor

@qtz1 qtz1 commented Jul 24, 2023 •
edited
Loading

Expose PrivateSettings interface as an internal type for the Firestore console. It was exported in the previous version of the non-modular firestore SDK we used in console.

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 65ee755

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (a5bf94c) and merge commit (8327105).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eBR6oEJYch.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (a5bf94c) and merge commit (8327105).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tKdy98LbkV.html

@qtz1 qtz1 marked this pull request as ready for review July 24, 2023 20:09
@qtz1 qtz1 requested review from a team as code owners July 24, 2023 20:09
dwyfrequency
dwyfrequency approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qtz1 qtz1 merged commit e037eee into master Aug 1, 2023
@qtz1 qtz1 deleted the firestore-console-typings branch August 1, 2023 16:18
@firebase firebase locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qtz1 @google-oss-bot @dwyfrequency