You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend will enforce a minimum password length of 6 even if no minimum password length is configured. I created a backend bug for this, but we will also default to using this value in the SDK if no minimum length is set.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This report is too large (139,506 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.
The reason will be displayed to describe this comment to others. Learn more.
Overall question - if backend is enforcing a min password length why do we still need to add extra logic in SDK? Would backend return 6 instead of null when using the default policy setup in the response?
Overall question - if backend is enforcing a min password length why do we still need to add extra logic in SDK? Would backend return 6 instead of null when using the default policy setup in the response?
This is a temporary solution since backend currently returns null. We can remove the extra logic once backend change is done.
Overall question - if backend is enforcing a min password length why do we still need to add extra logic in SDK? Would backend return 6 instead of null when using the default policy setup in the response?
This is a temporary solution since backend currently returns null. We can remove the extra logic once backend change is done.
Overall question - if backend is enforcing a min password length why do we still need to add extra logic in SDK? Would backend return 6 instead of null when using the default policy setup in the response?
This is a temporary solution since backend currently returns null. We can remove the extra logic once backend change is done.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ch5zzy
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
The backend will enforce a minimum password length of 6 even if no minimum password length is configured. I created a backend bug for this, but we will also default to using this value in the SDK if no minimum length is set.