Skip to content

Setup firestore tests for named db #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 4, 2023
Merged

Setup firestore tests for named db #7505

merged 15 commits into from
Aug 4, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jul 31, 2023

No description provided.

@wu-hui wu-hui requested review from a team as code owners July 31, 2023 15:37
@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1aeb561

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui force-pushed the wuandy/NamedDBTest branch from 3d3af34 to 1774754 Compare July 31, 2023 15:55
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (146b699) and merge commit (0df05bf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fCefqAoYfa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (146b699) and merge commit (0df05bf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nlqdFG0fGK.html

@wu-hui wu-hui requested a review from MarkDuckworth August 3, 2023 10:18
@wu-hui wu-hui requested a review from DellaBitta August 3, 2023 10:18
MarkDuckworth
MarkDuckworth approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments for your consideration.

@wu-hui wu-hui merged commit 0038e11 into master Aug 4, 2023
@wu-hui wu-hui deleted the wuandy/NamedDBTest branch August 4, 2023 17:28
@firebase firebase locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees

@MarkDuckworth MarkDuckworth

@DellaBitta DellaBitta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @google-oss-bot @MarkDuckworth @DellaBitta