-
Notifications
You must be signed in to change notification settings - Fork 945
Fix flaky auth webdriver tests #7582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (285,279 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
We currently pin Chrome v110 on CI as tests in https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/test/integration/webdriver/redirect.test.ts became flaky on version 111.
This change fixes these flaky tests and pins Chrome v114.
Why do we pin v114 but not install the latest Chrome version?
https://chromedriver.chromium.org/downloads only goes up to version 114, so ChromeDriver installation will fail with higher versions:
"No such object: chromedriver/LATEST_RELEASE_115.0.5790"
. According to that website, starting with version 115 these JSON endpoints should be used to determine compatible versions and download urls. Hence, we will pin v114 for now and update the script to install the latest ChromeDriver in another PR.Internal bug: b/297380444
I've tested this locally with the latest Chrome v116. All auth webdriver tests passed 7 times out of 7 runs.
CI tests with Chrome v114 also pass.