Skip to content

Firestore: Increase test coverage for persistent cache indexing #7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2023
Merged

Firestore: Increase test coverage for persistent cache indexing #7613

merged 3 commits into from
Sep 8, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 7, 2023

Port testing improvements for persistent cache auto indexing from the Android SDK: firebase/firebase-android-sdk#5213

@dconeybe dconeybe self-assigned this Sep 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 5590813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (320e58c) and merge commit (7903226).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/75tXcEnlFj.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (320e58c) and merge commit (7903226).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bKcImyGyat.html

@dconeybe dconeybe marked this pull request as ready for review September 7, 2023 16:27
@dconeybe dconeybe requested review from a team as code owners September 7, 2023 16:27
@dconeybe dconeybe requested a review from wu-hui September 7, 2023 16:28
@dconeybe dconeybe merged commit 98cfcbd into master Sep 8, 2023
@dconeybe dconeybe deleted the dconeybe/ClientSideIndexAutoCreationMoreTestsPortedFromAndroid branch September 8, 2023 16:55
@firebase firebase locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @wu-hui