Clean up and re-enable some OR query tests.

[ehsannas]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 367d9a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (3492066) and merge commit (91f9afc).

Test Logs

• Base (3492066): https://github.com/firebase/firebase-js-sdk/actions/runs/6238801447
• Merge (91f9afc): https://github.com/firebase/firebase-js-sdk/actions/runs/6307160562

1. https://storage.googleapis.com/firebase-sdk-metric-reports/8rXP4Swh0C.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (3492066) and merge commit (91f9afc).

Test Logs

• Base (3492066): https://github.com/firebase/firebase-js-sdk/actions/runs/6238801447
• Merge (91f9afc): https://github.com/firebase/firebase-js-sdk/actions/runs/6307160562

1. https://storage.googleapis.com/firebase-sdk-metric-reports/9Q03x9DND0.html

[milaGGL]

There are duplicate test cases in 2 "OR queries". Please remove it. for example:

firebase-js-sdk/packages/firestore/test/integration/api/query.test.ts

Line 2384 in e30d7a6

// Two IN operations on different fields with disjunction.

and

firebase-js-sdk/packages/firestore/test/integration/api/query.test.ts

Line 2116 in e30d7a6

// Two IN operations on different fields with disjunction.

[milaGGL]

In the second "OR queries", only 3 tests require composite index, 'can use query overloads','can use or queries','supports multiple in ops'.
I suggest merge all other test cases into one "OR queries", except for the above 3.

[ehsannas]

In the second "OR queries", only 3 tests require composite index, 'can use query overloads','can use or queries','supports multiple in ops'.
I suggest merge all other test cases into one "OR queries", except for the above 3.

Yep, I have

• Removed the duplicate tests that did not need a composite index.
• Kept can use query overloads and can use or queries
• Slightly modified supports multiple in ops so it doesn't need a composite index (by using an equality instead of inequality in the filter). This modification doesn't change what we're testing, and makes it possible to run without a composite index.

[milaGGL]

LGTM