Add unit tests for handleRecaptchaFlow #7699

renkelvin · 2023-10-14T00:02:26Z

Unit tests for #7666

This reverts commit 6b934c9.

This reverts commit 15ec2b5.

changeset-bot · 2023-10-14T00:02:36Z

⚠️ No Changeset found

Latest commit: 6b71639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2023-10-14T00:32:38Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
browser	176 kB	176 kB	+202 B (+0.1%)
cordova	204 kB	204 kB	+297 B (+0.1%)
esm5	229 kB	229 kB	+297 B (+0.1%)
main	173 kB	174 kB	+309 B (+0.2%)
module	176 kB	176 kB	+202 B (+0.1%)
react-native	192 kB	193 kB	+313 B (+0.2%)

@firebase/auth/cordova
Type Base (12ad9f1) Merge (f762ef7) Diff
browser 204 kB 204 kB +297 B (+0.1%)
module 204 kB 204 kB +297 B (+0.1%)
@firebase/auth/internal
Type Base (12ad9f1) Merge (f762ef7) Diff
browser 187 kB 187 kB +202 B (+0.1%)
esm5 242 kB 243 kB +297 B (+0.1%)
main 210 kB 210 kB +313 B (+0.1%)
module 187 kB 187 kB +202 B (+0.1%)

`@firebase/firestore-compat`

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
browser	20.5 kB	20.6 kB	+48 B (+0.2%)
esm5	27.6 kB	27.7 kB	+48 B (+0.2%)
main	20.9 kB	21.0 kB	+48 B (+0.2%)
module	20.5 kB	20.6 kB	+48 B (+0.2%)
react-native	20.5 kB	20.6 kB	+48 B (+0.2%)

bundle
Type Base (12ad9f1) Merge (f762ef7) Diff
auth (EmailAndPassword) 80.9 kB 80.9 kB +59 B (+0.1%)

`firebase`

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
firebase-auth-compat.js	136 kB	136 kB	+111 B (+0.1%)
firebase-auth-cordova.js	173 kB	173 kB	+261 B (+0.2%)
firebase-auth.js	146 kB	146 kB	+143 B (+0.1%)
firebase-compat.js	778 kB	778 kB	+138 B (+0.0%)
firebase-firestore-compat.js	340 kB	340 kB	+27 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XFEF3HZzxr.html

google-oss-bot · 2023-10-14T00:48:13Z

Size Analysis Report ¹

Affected Products

`@firebase/auth`

`EmailAuthCredential`

Size

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
size	42.6 kB	42.6 kB	+59 B (+0.1%)
size-with-ext-deps	63.4 kB	63.4 kB	+59 B (+0.1%)

Dependency

Type Base (12ad9f1) Merge (f762ef7) Diff

functions

63 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_prodErrorMap
_reloadWithoutSaving
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
mergeProviderData
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
updateEmailPassword
utcTimestampToDateString

63 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_prodErrorMap
_reloadWithoutSaving
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
linkEmailPassword
mergeProviderData
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
utcTimestampToDateString

+ linkEmailPassword
- updateEmailPassword

`EmailAuthProvider`

Size

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
size	44.0 kB	44.1 kB	+59 B (+0.1%)
size-with-ext-deps	65.0 kB	65.1 kB	+59 B (+0.1%)

Dependency

Type Base (12ad9f1) Merge (f762ef7) Diff

functions

65 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_prodErrorMap
_reloadWithoutSaving
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
mergeProviderData
parseDeepLink
parseMode
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
updateEmailPassword
utcTimestampToDateString

65 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_prodErrorMap
_reloadWithoutSaving
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
linkEmailPassword
mergeProviderData
parseDeepLink
parseMode
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
utcTimestampToDateString

+ linkEmailPassword
- updateEmailPassword

`signInWithEmailAndPassword`

Size

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
size	45.7 kB	45.7 kB	+59 B (+0.1%)
size-with-ext-deps	66.7 kB	66.8 kB	+59 B (+0.1%)

Dependency

Type Base (12ad9f1) Merge (f762ef7) Diff

functions

71 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reloadWithoutSaving
_signInWithCredential
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
mergeProviderData
parseDeepLink
parseMode
providerIdForResponse
recachePasswordPolicy
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithCredential
signInWithEmailAndPassword
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
updateEmailPassword
utcTimestampToDateString

71 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reloadWithoutSaving
_signInWithCredential
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
linkEmailPassword
mergeProviderData
parseDeepLink
parseMode
providerIdForResponse
recachePasswordPolicy
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithCredential
signInWithEmailAndPassword
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
utcTimestampToDateString

+ linkEmailPassword
- updateEmailPassword

`signInWithEmailLink`

Size

Type	Base (`12ad9f1`)	Merge (`f762ef7`)	Diff
size	45.7 kB	45.7 kB	+59 B (+0.1%)
size-with-ext-deps	66.7 kB	66.8 kB	+59 B (+0.1%)

Dependency

Type Base (12ad9f1) Merge (f762ef7) Diff

functions

71 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reloadWithoutSaving
_signInWithCredential
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
mergeProviderData
parseDeepLink
parseMode
providerIdForResponse
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithCredential
signInWithEmailLink
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
updateEmailPassword
utcTimestampToDateString

71 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getPasswordPolicy
_getUserLanguage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_loadJS
_logError
_logWarn
_logoutIfInvalidated
_makeTaggedError
_parseEnforcementState
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reloadWithoutSaving
_signInWithCredential
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
extractProviderData
getAccountInfo
getIdTokenResult
getRecaptchaConfig
getScriptParentElement
getVersionForPlatform
handleRecaptchaFlow
injectRecaptchaFields
isEnterprise
isUserInvalidated
linkEmailPassword
mergeProviderData
parseDeepLink
parseMode
providerIdForResponse
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
signInWithCredential
signInWithEmailLink
signInWithEmailLink$1
signInWithEmailLinkForLinking
signInWithPassword
utcTimestampToDateString

+ linkEmailPassword
- updateEmailPassword

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/tuynqRdzMu.html

renkelvin · 2023-10-16T03:43:15Z

@prameshj please take a look.

packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.test.ts

prameshj

Thanks for adding this!

This reverts commit 6b934c9.

…into re-tests

github-actions · 2023-10-30T17:54:01Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

renkelvin · 2023-10-30T19:00:29Z

Hey @hsubox76 , could you help take a look? Thanks!

hsubox76

Since it's just unit tests and doesn't need a release, I don't think it needs a changeset.

This reverts commit 3c85c72.

renkelvin added 6 commits October 13, 2023 16:59

Create handleRecaptchaFlow helper method

0e48d5b

Revert "Create handleRecaptchaFlow helper method"

3307fe5

This reverts commit 6b934c9.

Add handleRecaptchaFlow

7174365

Revert tests

8185450

Integration

7bd54ae

Revert "Revert tests"

d311ea4

This reverts commit 15ec2b5.

renkelvin added 7 commits October 13, 2023 19:37

Update recaptcha_enterprise_verifier.test.ts

eeec05a

Update recaptcha_enterprise_verifier.test.ts

102f9fa

Update recaptcha_enterprise_verifier.test.ts

81f5662

Update recaptcha_enterprise_verifier.test.ts

eff15ef

Update recaptcha_enterprise_verifier.test.ts

0682586

Update recaptcha_enterprise_verifier.test.ts

5bb3cb4

Update recaptcha_enterprise_verifier.test.ts

1a582a8

renkelvin marked this pull request as ready for review October 16, 2023 03:42

renkelvin requested review from lisajian, prameshj, sam-gc and a team as code owners October 16, 2023 03:42

prameshj reviewed Oct 27, 2023

View reviewed changes

packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.test.ts Show resolved Hide resolved

prameshj approved these changes Oct 27, 2023

View reviewed changes

renkelvin added 2 commits October 27, 2023 12:39

Update recaptcha_enterprise_verifier.test.ts

fe18400

Create flat-seals-bathe.md

952b0af

renkelvin requested review from a team as code owners October 27, 2023 23:56

renkelvin added 2 commits October 30, 2023 10:50

Create handleRecaptchaFlow helper method

b88cdb3

Revert "Create handleRecaptchaFlow helper method"

90ea7f5

This reverts commit 6b934c9.

renkelvin added 2 commits October 30, 2023 10:51

Create flat-seals-bathe.md

3c85c72

Merge branch 're-tests' of https://github.com/firebase/firebase-js-sdk …

9a97aab

…into re-tests

renkelvin requested review from egilmorez, markarndt, kevinthecheung, hsubox76, erikeldridge, jposuna, avolkovi, yoyomyo, zwu52, maneesht, tonyjhuang, jsdt and jmwski as code owners October 30, 2023 17:52

Update recaptcha_enterprise_verifier.test.ts

ad5fb49

renkelvin changed the base branch from master to WebOTP October 30, 2023 17:57

renkelvin requested review from yuchenshi and dwyfrequency as code owners October 30, 2023 17:57

renkelvin changed the base branch from WebOTP to master October 30, 2023 17:57

renkelvin added 2 commits October 30, 2023 10:58

Delete lucky-dragons-juggle.md

9065ee5

Update recaptcha_enterprise_verifier.test.ts

ddb1cd4

hsubox76 approved these changes Nov 1, 2023

View reviewed changes

Revert "Create flat-seals-bathe.md"

6b71639

This reverts commit 3c85c72.

renkelvin merged commit ff1a6ec into master Nov 1, 2023

renkelvin deleted the re-tests branch November 1, 2023 20:45

prameshj pushed a commit that referenced this pull request Nov 13, 2023

Add unit tests for handleRecaptchaFlow (#7699)

ccd3fe4

firebase locked and limited conversation to collaborators Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add unit tests for handleRecaptchaFlow #7699

Add unit tests for handleRecaptchaFlow #7699

Uh oh!

renkelvin commented Oct 14, 2023 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 14, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Oct 14, 2023 •

edited

Loading

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/firestore-compat`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Oct 14, 2023 •

edited

Loading

`@firebase/auth`

`EmailAuthCredential`

`EmailAuthProvider`

`signInWithEmailAndPassword`

`signInWithEmailLink`

Uh oh!

renkelvin commented Oct 16, 2023

Uh oh!

Uh oh!

prameshj left a comment

Uh oh!

github-actions bot commented Oct 30, 2023 •

edited

Loading

Uh oh!

renkelvin commented Oct 30, 2023

Uh oh!

hsubox76 left a comment

Uh oh!

Uh oh!

Add unit tests for handleRecaptchaFlow #7699

Add unit tests for handleRecaptchaFlow #7699

Uh oh!

Conversation

renkelvin commented Oct 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Oct 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/firestore-compat

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Oct 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/auth

EmailAuthCredential

EmailAuthProvider

signInWithEmailAndPassword

signInWithEmailLink

Test Logs

Uh oh!

renkelvin commented Oct 16, 2023

Uh oh!

Uh oh!

prameshj left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

renkelvin commented Oct 30, 2023

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

renkelvin commented Oct 14, 2023 •

edited

Loading

changeset-bot bot commented Oct 14, 2023 •

edited

Loading

google-oss-bot commented Oct 14, 2023 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/firestore-compat`

`bundle`

`firebase`

google-oss-bot commented Oct 14, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`EmailAuthCredential`

`EmailAuthProvider`

`signInWithEmailAndPassword`

`signInWithEmailLink`

github-actions bot commented Oct 30, 2023 •

edited

Loading