Skip to content

Rolling back the use of useFetchStreams, which has lead to hanging queries. #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Rolling back the use of useFetchStreams, which has lead to hanging queries. #7729

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2af182a
Rolling back the use of useFetchStreams, which has lead to hanging qu…
MarkDuckworth Oct 26, 2023
896feb2
Create real-ants-notice.md
MarkDuckworth Oct 26, 2023
e536dd4
Address PR feedback.
MarkDuckworth Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-ants-notice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/firestore": patch
---

Rolling back the use of useFetchStreams, which has lead to hanging and incomplete queries.
7 changes: 5 additions & 2 deletions packages/firestore/src/platform/browser/webchannel_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import {
EventTarget,
StatEvent,
Event,
Stat
Stat,
FetchXmlHttpFactory
} from '@firebase/webchannel-wrapper';

import { Token } from '../../api/credentials';
Expand Down Expand Up @@ -208,7 +209,9 @@ export class WebChannelConnection extends RestConnection {
}

if (this.useFetchStreams) {
request.useFetchStreams = true;
// When b/307942499 is fixed, revert to the following line:
// request.useFetchStreams = true;
request.xmlHttpFactory = new FetchXmlHttpFactory({});
}

this.modifyHeadersForRequest(
Expand Down