Fix GitHub Action Worfklow env configuration of node 'max_old_space_size'. #7785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (ebc694a) and merge commit (29b0018).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (ebc694a) and merge commit (29b0018).Test Logs |
hsubox76
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
TLDR; This change migrates the configuration of NODE_OPTIONS from shell commands within individual jobs, to GitHub Workflow
env:directives which apply to all jobs on the runner.Our workflows attempted to configure the NODE_OPTIONS environment variable by executing the following shell command:
This was once supported by GitHub Actions, but no more. Attempts at env config in this way produces errors in our workflows and the configuration fails to stick. In the worst case, this could be part of test flakiness, but at the least it's producing needless error messages in the Annotation section our Workflow results. To fix this, replace the errant shell-based env configuration with the GitHub Workflow sanctioned method of setting environment variables.
Testing
CI Run (below).
API Changes
N/A.