Skip to content

Firestore: Improve test name of "missing index" error message tests #7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Firestore: Improve test name of "missing index" error message tests #7875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7af522
rename tests 'error message is good' -> 'error message contains conso…
dconeybe Dec 14, 2023
ba9bd74
yarn changeset add --empty
dconeybe Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/long-rats-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 2 additions & 2 deletions packages/firestore/test/integration/api/aggregation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ apiDescribe('Count queries', persistence => {
// and will, therefore, never fail in this situation.
// eslint-disable-next-line no-restricted-properties
(USE_EMULATOR ? it.skip : it)(
'getCountFromServer error message is good if missing index',
'getCountFromServer error message contains console link if missing index',
() => {
return withEmptyTestCollection(persistence, async coll => {
const query_ = query(
Expand Down Expand Up @@ -342,7 +342,7 @@ apiDescribe('Aggregation queries', persistence => {
// and will, therefore, never fail in this situation.
// eslint-disable-next-line no-restricted-properties
(USE_EMULATOR ? it.skip : it)(
'getAggregateFromServer error message is good if missing index',
'getAggregateFromServer error message contains console link good if missing index',
() => {
return withEmptyTestCollection(persistence, async coll => {
const query_ = query(
Expand Down
4 changes: 2 additions & 2 deletions packages/firestore/test/lite/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2406,7 +2406,7 @@ describe('Count queries', () => {
// and will, therefore, never fail in this situation.
// eslint-disable-next-line no-restricted-properties
(USE_EMULATOR ? it.skip : it)(
'getCount error message is good if missing index',
'getCount error message contains console link if missing index',
() => {
return withTestCollection(async coll => {
const query_ = query(
Expand Down Expand Up @@ -2713,7 +2713,7 @@ describe('Aggregate queries', () => {
// and will, therefore, never fail in this situation.
// eslint-disable-next-line no-restricted-properties
(USE_EMULATOR ? it.skip : it)(
'getAggregate error message is good if missing index',
'getAggregate error message contains console link if missing index',
() => {
return withTestCollection(async coll => {
const query_ = query(
Expand Down