Firestore: local_store_indexeddb.test.ts: fix spurious errors on test cleanup

[dconeybe]

Fix some spurious test failures that get reported if some of the "before" actions of a test fail. Specifically, calling

persistence.shutdown()

would throw a

Uncaught TypeError: Cannot read properties of undefined

error if the "before" step that initialized the persistence variable failed before setting it.

Although this isn't a problem, it adds noise to a test failure that may already be difficult enough to debug.

The fix is simple: just conditionally call the method only if the object is defined; that is, change it to

persistence?.shutdown()

[changeset-bot]

⚠️ No Changeset found

Latest commit: b419a7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (7f78362) and merge commit (2ea5742).

Test Logs

• Base (7f78362): https://github.com/firebase/firebase-js-sdk/actions/runs/7413390661
• Merge (2ea5742): https://github.com/firebase/firebase-js-sdk/actions/runs/7426411945

1. https://storage.googleapis.com/firebase-sdk-metric-reports/mSE4OBf7oz.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (7f78362) and merge commit (2ea5742).

Test Logs

• Base (7f78362): https://github.com/firebase/firebase-js-sdk/actions/runs/7413390661
• Merge (2ea5742): https://github.com/firebase/firebase-js-sdk/actions/runs/7426411945

1. https://storage.googleapis.com/firebase-sdk-metric-reports/hcX6L6q6zy.html