Skip to content

Firestore: FirestoreDataConverter doc and test improvements #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 17, 2024
Merged

Firestore: FirestoreDataConverter doc and test improvements #7932

merged 6 commits into from
Jan 17, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 9, 2024 •
edited
Loading

Improve the documentation and unit tests for FirestoreDataConverter, based on feedback left on #7310.

This PR was ported to the nodejs-firestore sdk in #7932.

Googlers see b/289520317 for details.

@dconeybe dconeybe self-assigned this Jan 9, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3b5f66a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe mentioned this pull request Jan 9, 2024
Merged
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 9, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (d7ace80) and merge commit (574a276).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UHwghpTxtV.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 9, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (d7ace80) and merge commit (574a276).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HjJGyfzdPP.html

@dconeybe dconeybe changed the title Firestore: FirestoreDataConverter doc improvements Firestore: FirestoreDataConverter doc and test improvements Jan 11, 2024
@dconeybe dconeybe marked this pull request as ready for review January 11, 2024 20:07
MarkDuckworth
MarkDuckworth approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions.

MarkDuckworth
MarkDuckworth approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big readability improvements across the PR!

@dconeybe
Copy link
Contributor Author

@egilmorez Please review for docs changes. Thanks!

@dconeybe dconeybe merged commit e9869c4 into master Jan 17, 2024
@dconeybe dconeybe deleted the dconeybe/UpdateDataDocAndTestImprovements branch January 17, 2024 22:10
@dconeybe dconeybe mentioned this pull request Jan 23, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@markarndt markarndt markarndt approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees

@MarkDuckworth MarkDuckworth

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dconeybe @google-oss-bot @MarkDuckworth @markarndt