Prepare for public preview release #8214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57f6c0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (176,140 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Size Analysis Report 1This report is too large (176,140 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
approved these changes
May 3, 2024
packages/vertexai/package.json
Outdated
| "description": "A template package for new firebase packages", | ||
| "name": "@firebase/vertexai-preview", | ||
| "version": "0.0.0", | ||
| "description": "A Firebase SDK for VertexAI", |
There was a problem hiding this comment.
Suggestion: maybe we should we note that it's a preview version here in the description?
There was a problem hiding this comment.
Added, hopefully we catch this string when we go GA!
| @@ -45,20 +45,26 @@ declare module '@firebase/component' { | |||
| export function getVertexAI(app: FirebaseApp = getApp()): VertexAI { | |||
| app = getModularInstance(app); | |||
| // Dependencies | |||
| const vertexProvider: Provider<'vertex'> = _getProvider(app, VERTEX_TYPE); | |||
| const vertexProvider: Provider<'vertexAI'> = _getProvider(app, VERTEX_TYPE); | |||
There was a problem hiding this comment.
Could change Provider<`vertexAI`> to Provider<VERTEX_TYPE> here, I think.
There was a problem hiding this comment.
Sadly I cannot, Typescript can't turn an actual code string into a string that you use for typing.
| @@ -74,6 +74,11 @@ export interface GenerateContentResponse { | |||
| usageMetadata?: UsageMetadata; | |||
| } | |||
|
|
|||
| /** | |||
| * Usage metadata about response. | |||
There was a problem hiding this comment.
Could even link to GenerateContentResponse, will do that.
dlarocque
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-reportnpm script so that it will be picked up by the docgen process (will generate docs in a separate PR)ch-vertex-featurebranch being merged intomaster, so that's why it includes@firebase/app.I did not rename the directory
packages/vertexaibecause I didn't want this PR to have a 140 file diff. It should be fine, the dirname isn't published to NPM.