Skip to content

Integrate VertexAI with Auth #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

dlarocque
Copy link
Contributor

Integrating VertexAI with Auth, so that when Firebase Auth is available and signed in, we append an Authorization: Firebase <authToken> header to requests.

This is needed in order to support GCS URI FileData support.

@dlarocque dlarocque requested review from a team as code owners May 3, 2024 17:39
Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: d24567b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque requested review from hsubox76 and DellaBitta May 3, 2024 17:39
@dlarocque dlarocque force-pushed the dlarocque/vertexai-auth-interop branch from 4ea1a7e to 025d42c Compare May 3, 2024 17:42
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 3, 2024

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (964bd26)Merge (18bfed6)Diff
    browser24.6 kB25.1 kB+440 B (+1.8%)
    main25.2 kB25.7 kB+440 B (+1.7%)
    module24.6 kB25.1 kB+440 B (+1.8%)
  • firebase

    TypeBase (964bd26)Merge (18bfed6)Diff
    firebase-vertexai.js18.9 kB19.2 kB+296 B (+1.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pfYXyF03j9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 3, 2024

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • BlockReason

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.3 kB+129 B (+0.6%)
    • ChatSession

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size14.1 kB14.4 kB+264 B (+1.9%)
      size-with-ext-deps32.5 kB32.8 kB+264 B (+0.8%)
    • FinishReason

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.3 kB+129 B (+0.6%)
    • FunctionCallingMode

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.54 kB3.67 kB+129 B (+3.6%)
      size-with-ext-deps21.2 kB21.4 kB+129 B (+0.6%)
    • FunctionDeclarationSchemaType

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.55 kB3.68 kB+129 B (+3.6%)
      size-with-ext-deps21.2 kB21.4 kB+129 B (+0.6%)
    • GenerativeModel

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size16.3 kB16.6 kB+328 B (+2.0%)
      size-with-ext-deps34.7 kB35.0 kB+328 B (+0.9%)
    • HarmBlockMethod

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.4 kB+129 B (+0.6%)
    • HarmBlockThreshold

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.54 kB3.67 kB+129 B (+3.6%)
      size-with-ext-deps21.2 kB21.4 kB+129 B (+0.6%)
    • HarmCategory

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.3 kB+129 B (+0.6%)
    • HarmProbability

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.4 kB+129 B (+0.6%)
    • HarmSeverity

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.53 kB3.66 kB+129 B (+3.7%)
      size-with-ext-deps21.2 kB21.3 kB+129 B (+0.6%)
    • POSSIBLE_ROLES

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.58 kB3.71 kB+129 B (+3.6%)
      size-with-ext-deps21.3 kB21.4 kB+129 B (+0.6%)
    • getGenerativeModel

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size16.4 kB16.7 kB+328 B (+2.0%)
      size-with-ext-deps34.8 kB35.1 kB+328 B (+0.9%)
    • getVertexAI

      Size

      TypeBase (964bd26)Merge (18bfed6)Diff
      size3.71 kB3.83 kB+129 B (+3.5%)
      size-with-ext-deps28.7 kB28.8 kB+129 B (+0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rfTi76cMrl.html

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can merge this now because the backend will just ignore the auth token at this time. Double check with Andrew that Swift, etc. are taking that approach? If merging it into the feature branch, remove the changeset first.

@dlarocque dlarocque force-pushed the dlarocque/vertexai-auth-interop branch from 025d42c to dddb566 Compare May 6, 2024 14:59
@dlarocque dlarocque force-pushed the dlarocque/vertexai-auth-interop branch from dddb566 to d24567b Compare May 6, 2024 19:03
@dlarocque dlarocque merged commit 070e0cc into ch-vertex-feature May 6, 2024
33 of 35 checks passed
@dlarocque dlarocque deleted the dlarocque/vertexai-auth-interop branch May 6, 2024 19:14
@hsubox76 hsubox76 mentioned this pull request May 7, 2024
@firebase firebase locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants