Skip to content

fix: Fix a typo in the webchannel-wrapper's package.json. #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: Fix a typo in the webchannel-wrapper's package.json. #8331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ea2869
fix: Fix a typo in the webchannel-wrapper's package.json.
ehsannas Jun 21, 2024
082337f
Create orange-rings-own.md
ehsannas Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-rings-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/webchannel-wrapper": patch
---

fix: Fix a typo in the webchannel-wrapper's package.json that affected ems5 exports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by comment: there is a typo in the release notes: "ems5" should be "esm5". That is proving to be a difficult acronym to spell correctly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsannas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch :(

It seems that this doesn't show up on the release notes (https://firebase.google.com/support/release-notes/js) page though (because it's a webchannel-wrapper package change?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure about webchannel-wrapper release notes showing up. Maybe they're not included, but, rather, expect to be mentioned by the dependents upgrading their dependency (i.e. a Firestore change that has its own release note that goes with the webchanne-wrapper upgrade).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I wrote the release notes for the 10.12.3 release where this went out. I mistakingly excluded this from the release notes. Looking at older release notes, we list changes to webchannel-wrapper under Firestore.

Sorry if I caused any confusion- I'll create a CL to mention this change in the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the typo in your CL then. Thanks @dlarocque.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as reviewer for your CL. Thanks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as reviewer for your CL. Thanks :)

Sounds good. I added you as a reviewer

2 changes: 1 addition & 1 deletion packages/webchannel-wrapper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"./bloom-blob": {
"types": "./dist/bloom-blob/bloom_blob_types.d.ts",
"require": "./dist/bloom-blob/bloom_blob_es2018.js",
"es5": "./dist/bloom-blob/bloom_blob_es5.js",
"esm5": "./dist/bloom-blob/bloom_blob_es5.js",
"default": "./dist/bloom-blob/esm/bloom_blob_es2018.js"
},
"./package.json": "./package.json"
Expand Down
Loading