Skip to content

VertexAI: add support for mock responses versioning system #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2024
Merged

VertexAI: add support for mock responses versioning system #8361

merged 4 commits into from
Jul 15, 2024

Conversation

tanzimfh
Copy link
Contributor

@tanzimfh tanzimfh commented Jul 8, 2024

This adds a new script that clones the latest minor version within a hard-coded major version of the mock responses.

It also adds a CI job that leaves a comment on the PR if the script is cloning an outdated major version.

@tanzimfh tanzimfh requested a review from a team as a code owner July 8, 2024 22:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f1ea95d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (52f8deb) and merge commit (629a9ac).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PgyJup6IBJ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (52f8deb) and merge commit (629a9ac).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2gNhRADHiQ.html

@tanzimfh tanzimfh marked this pull request as draft July 8, 2024 22:47
@tanzimfh tanzimfh marked this pull request as ready for review July 10, 2024 13:34
rlazo
rlazo reviewed Jul 10, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v2.0

@tanzimfh tanzimfh merged commit 4b4db85 into master Jul 15, 2024
35 checks passed
@tanzimfh tanzimfh deleted the tanzim/semver branch July 15, 2024 17:17
tom-andersen pushed a commit that referenced this pull request Jul 24, 2024
@tanzimfh @tom-andersen
VertexAI: add support for mock responses versioning system (#8361)
5676813
@firebase firebase locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanzimfh @google-oss-bot @rlazo @hsubox76