You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script that runs the tests in CI accepts a -s flag we can use to pass one test command we want to run in CI. We were passing two commands, and only the first one (test:browser) was being run, skipping the Node tests. Now we only pass one command test, which runs both.
Since the Node tests in storage are currently failing, this means CI is now red until we fix it.
Question: Do we need to merge the fix for storage into this branch, so that we avoid CI being red in master?
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The script that runs the tests in CI accepts a `-s` flag we use to pass
the test command we want to run in CI. We were passing two commands, and
only the first one (`test:browser`) was being run, skipping the Node
tests. Now we only pass one command `test`, which runs both.
The reason will be displayed to describe this comment to others. Learn more.
My only comment would be that I guess we deliberately removed the lint job from ci tests in order to run them in a separate workflow so I think technically we make another script here that doesn't run lint (seems to be called "test:all" in other packages), but I don't think it's that important.
My only comment would be that I guess we deliberately removed the lint job from ci tests in order to run them in a separate workflow so I think technically we make another script here that doesn't run lint (seems to be called "test:all" in other packages), but I don't think it's that important.
I agree that we shouldn't run lint when testing, but I noticed that a lot of packages do this. Is this something we want to change in all packages?
My only comment would be that I guess we deliberately removed the lint job from ci tests in order to run them in a separate workflow so I think technically we make another script here that doesn't run lint (seems to be called "test:all" in other packages), but I don't think it's that important.
I agree that we shouldn't run lint when testing, but I noticed that a lot of packages do this. Is this something we want to change in all packages?
If it's in other packages, we can do another PR that gets them all later. This PR should be good to go.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dlarocque
force-pushed
the
dlarocque/ci-fix
branch
from
The script that runs the tests in CI accepts a
-sflag we can use to pass one test command we want to run in CI. We were passing two commands, and only the first one (test:browser) was being run, skipping the Node tests. Now we only pass one commandtest, which runs both.Since the Node tests in storage are currently failing, this means CI is now red until we fix it.
Question: Do we need to merge the fix for storage into this branch, so that we avoid CI being red in master?