Skip to content

Refactor stream #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

Refactor stream #8376

merged 2 commits into from
Jul 24, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jul 18, 2024 •
edited
Loading

This prepares for InitilaizeStream handshake by moving the logic to AbstractStream that distinguishes first response subsequent stream responses. The Listen stream will make use of this in future PRs.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a6fe446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 18, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
    browser378 kB378 kB+99 B (+0.0%)
    esm5363 kB363 kB+121 B (+0.0%)
    main582 kB582 kB+147 B (+0.0%)
    module378 kB378 kB+99 B (+0.0%)
    react-native378 kB378 kB+99 B (+0.0%)

  • bundle

    TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
    firestore (CSI Auto Indexing Disable and Delete)268 kB268 kB+56 B (+0.0%)
    firestore (CSI Auto Indexing Enable)268 kB268 kB+56 B (+0.0%)
    firestore (Persistence)303 kB303 kB+81 B (+0.0%)
    firestore (Query Cursors)240 kB240 kB+66 B (+0.0%)
    firestore (Query)238 kB238 kB+66 B (+0.0%)
    firestore (Read data once)226 kB226 kB+66 B (+0.0%)
    firestore (Read Write w Persistence)322 kB323 kB+81 B (+0.0%)
    firestore (Realtime updates)228 kB228 kB+66 B (+0.0%)
    firestore (Write data)205 kB205 kB+56 B (+0.0%)

  • firebase

    TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
    firebase-compat.js789 kB789 kB+77 B (+0.0%)
    firebase-firestore-compat.js341 kB341 kB+76 B (+0.0%)
    firebase-firestore.js437 kB437 kB+99 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EUI7GDYZCR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 18, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size124 kB124 kB+55 B (+0.0%)
      size-with-ext-deps196 kB196 kB+56 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size115 kB115 kB+55 B (+0.0%)
      size-with-ext-deps186 kB187 kB+56 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size186 kB186 kB+55 B (+0.0%)
      size-with-ext-deps258 kB258 kB+56 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size222 kB223 kB+80 B (+0.0%)
      size-with-ext-deps294 kB294 kB+81 B (+0.0%)

    • executeWrite

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size114 kB114 kB+55 B (+0.0%)
      size-with-ext-deps186 kB186 kB+56 B (+0.0%)

    • getDoc

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size145 kB145 kB+66 B (+0.0%)
      size-with-ext-deps216 kB216 kB+66 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size145 kB145 kB+66 B (+0.0%)
      size-with-ext-deps216 kB217 kB+66 B (+0.0%)

    • getDocs

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size146 kB146 kB+66 B (+0.0%)
      size-with-ext-deps218 kB218 kB+66 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size146 kB146 kB+66 B (+0.0%)
      size-with-ext-deps218 kB218 kB+66 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size147 kB147 kB+66 B (+0.0%)
      size-with-ext-deps219 kB219 kB+66 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size136 kB136 kB+66 B (+0.0%)
      size-with-ext-deps208 kB208 kB+66 B (+0.0%)

    • persistentLocalCache

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size184 kB184 kB+55 B (+0.0%)
      size-with-ext-deps255 kB256 kB+56 B (+0.0%)

    • persistentMultipleTabManager

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size219 kB219 kB+80 B (+0.0%)
      size-with-ext-deps291 kB291 kB+81 B (+0.0%)

    • persistentSingleTabManager

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size183 kB183 kB+55 B (+0.0%)
      size-with-ext-deps255 kB255 kB+56 B (+0.0%)

    • setDoc

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size123 kB123 kB+55 B (+0.0%)
      size-with-ext-deps195 kB195 kB+56 B (+0.0%)

    • updateDoc

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size124 kB124 kB+55 B (+0.0%)
      size-with-ext-deps195 kB195 kB+56 B (+0.0%)

    • writeBatch

      Size

      TypeBase (fd8bd4b)Merge (2a1f0a0)Diff
      size126 kB126 kB+55 B (+0.0%)
      size-with-ext-deps197 kB197 kB+56 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jzjjjLMpz4.html

@tom-andersen tom-andersen marked this pull request as ready for review July 19, 2024 14:52
@tom-andersen tom-andersen requested review from a team as code owners July 19, 2024 14:52
@tom-andersen tom-andersen requested a review from wu-hui July 19, 2024 14:52
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Jul 23, 2024
@tom-andersen tom-andersen merged commit 46da093 into master Jul 24, 2024
43 checks passed
@tom-andersen tom-andersen deleted the tomandersen/refactorStream branch July 24, 2024 14:51
@firebase firebase locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-andersen @google-oss-bot @wu-hui