Skip to content

Fix changeset checker #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix changeset checker #8392

merged 3 commits into from
Jul 25, 2024

Conversation

hsubox76
Copy link
Contributor

Our changeset_checker script's primary job is to check if any package has a minor bump and remind us to bump firebase to a minor if so. There's a separate changesets actions bot whose job is to check if there are any changesets at all, so our script can ignore checking for that. There seems to be another message pattern we haven't accounted for indicating that there are no changesets. Added that to the check.

This avoids false errors like the below (second message in screenshot).
image

Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: aeeee36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review July 24, 2024 22:00
@hsubox76 hsubox76 requested a review from a team as a code owner July 24, 2024 22:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2024

@hsubox76 hsubox76 requested review from DellaBitta and dlarocque July 24, 2024 22:14
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 24, 2024

@hsubox76 hsubox76 merged commit 6266124 into master Jul 25, 2024
35 checks passed
@hsubox76 hsubox76 deleted the ch-changeset-test-2 branch July 25, 2024 17:46
@firebase firebase locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants