Introduce Safari browser testing #8396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (150,199 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
dlarocque
force-pushed
the
dlarocque/karma-safari
branch
4 times, most recently
from
2a43d59 to
5b2cad7
Compare
dlarocque
requested review from
lisajian,
Xiaoshouzi-gh and
sam-gc
as code owners
dlarocque
force-pushed
the
dlarocque/karma-safari
branch
2 times, most recently
from
b2e32d2 to
e8d9bd6
Compare
hsubox76
reviewed
Jul 30, 2024
dlarocque
force-pushed
the
dlarocque/karma-safari
branch
from
e8d9bd6 to
849be6a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to bring back cross-browser testing to the SDK.
This PR includes a custom Karma plugin,
karma-safari-launcher, that is forked from https://github.com/karma-runner/karma-safari-launcher. The original plugin is no longer maintained, and has been broken since 2018. This custom plugin fixes the main issue with the previous plugin, where a file picker dialog is opened when Safari is launched, since we attempt to open a file that is opened outside of the Safari data directory (Library/Containers/com.apple.Safari/Data). To fix the issue, we open an HTML trampoline in the Safari data directory, that then redirects us to the URL where the karma tests are hosted.