Skip to content

Abort Firestore listeners on terminate. #8399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jul 29, 2024

In preparation for clearing cache on named database reuse, listeners need to abort when FirestoreClient is terminated.

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: fda04f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tom-andersen tom-andersen changed the title Abort onSnapshotListeners on terminate. Abort Firestore listeners on terminate. Jul 29, 2024
@tom-andersen tom-andersen marked this pull request as ready for review July 29, 2024 04:18
@tom-andersen tom-andersen requested review from a team as code owners July 29, 2024 04:18
@tom-andersen tom-andersen force-pushed the tomandersen/abortSnapshotListenersOnTerminate branch from 0fafd41 to 085499b Compare July 29, 2024 04:21
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 29, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (3f2c12a)Merge (6967e0e)Diff
    browser378 kB378 kB+394 B (+0.1%)
    esm5363 kB363 kB+318 B (+0.1%)
    main582 kB582 kB+503 B (+0.1%)
    module378 kB378 kB+394 B (+0.1%)
    react-native378 kB379 kB+394 B (+0.1%)
  • bundle

    TypeBase (3f2c12a)Merge (6967e0e)Diff
    firestore (CSI Auto Indexing Disable and Delete)268 kB268 kB+261 B (+0.1%)
    firestore (CSI Auto Indexing Enable)268 kB268 kB+261 B (+0.1%)
    firestore (Persistence)303 kB303 kB+261 B (+0.1%)
    firestore (Query Cursors)240 kB240 kB+261 B (+0.1%)
    firestore (Query)238 kB238 kB+261 B (+0.1%)
    firestore (Read data once)226 kB226 kB+261 B (+0.1%)
    firestore (Read Write w Persistence)323 kB323 kB+261 B (+0.1%)
    firestore (Realtime updates)228 kB229 kB+261 B (+0.1%)
    firestore (Transaction)205 kB205 kB+261 B (+0.1%)
    firestore (Write data)205 kB205 kB+261 B (+0.1%)
  • firebase

    TypeBase (3f2c12a)Merge (6967e0e)Diff
    firebase-compat.js786 kB786 kB+251 B (+0.0%)
    firebase-firestore-compat.js341 kB342 kB+249 B (+0.1%)
    firebase-firestore.js437 kB437 kB+395 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R6rj3japLj.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 29, 2024

Size Analysis Report 1

This report is too large (299,332 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/T2myHJVzzu.html

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Jul 30, 2024
@tom-andersen tom-andersen merged commit aef5468 into main Jul 30, 2024
43 checks passed
@tom-andersen tom-andersen deleted the tomandersen/abortSnapshotListenersOnTerminate branch July 30, 2024 20:20
@firebase firebase locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants