Skip to content

Exclude .git from archived build, instead of deleting it #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

dlarocque
Copy link
Contributor

Instead of having an additional step to delete the .git directory before archiving it, we can directly exclude it from the archived build with --exclude.

Firestore is already doing this here: https://github.com/firebase/firebase-js-sdk/blob/main/.github/workflows/test-changed-firestore.yml#L71

@dlarocque dlarocque requested a review from hsubox76 July 30, 2024 16:03
@dlarocque dlarocque requested a review from a team as a code owner July 30, 2024 16:03
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: d00e66d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, neat.

@dlarocque dlarocque merged commit 6c3acf5 into main Jul 30, 2024
35 checks passed
@dlarocque dlarocque deleted the dlarocque/tar-exclude branch July 30, 2024 20:51
@firebase firebase locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants