Skip to content

Set github actions to use commit hashes #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Set github actions to use commit hashes #8852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cfe966
set github actions to use commit hashes
hsubox76 Mar 19, 2025
96e9bff
use full hash
hsubox76 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/check-changeset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,25 @@ jobs:
- name: Print blocking failure status
run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}"
- name: Find Comment
uses: peter-evans/find-comment@v3
# This commit represents v3.1.0
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
id: fc
with:
issue-number: ${{github.event.number}}
body-includes: Changeset File Check
- name: Create comment (missing packages)
if: ${{!steps.fc.outputs.comment-id && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
uses: peter-evans/create-or-update-comment@v4
# This commit represents v4.0.0
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
issue-number: ${{github.event.number}}
body: |
### Changeset File Check :warning:
${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
- name: Update comment (missing packages)
if: ${{steps.fc.outputs.comment-id && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
uses: peter-evans/create-or-update-comment@v4
# This commit represents v4.0.0
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
comment-id: ${{steps.fc.outputs.comment-id}}
edit-mode: replace
Expand All @@ -81,7 +84,8 @@ jobs:
${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
- name: Update comment (no missing packages)
if: ${{steps.fc.outputs.comment-id && !steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}
uses: peter-evans/create-or-update-comment@v4
# This commit represents v4.0.0
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
comment-id: ${{steps.fc.outputs.comment-id}}
edit-mode: replace
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/check-vertexai-responses.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,16 @@ jobs:
echo "latest_tag=$LATEST" >> $GITHUB_ENV
working-directory: packages/vertexai/test-utils/vertexai-sdk-test-data
- name: Find comment from previous run if exists
uses: peter-evans/find-comment@v3
# This commit represents v3.1.0
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
id: fc
with:
issue-number: ${{github.event.number}}
body-includes: Vertex AI Mock Responses Check
- name: Comment on PR if newer version is available
if: ${{env.cloned_tag != env.latest_tag && !steps.fc.outputs.comment-id}}
uses: peter-evans/create-or-update-comment@v4
# This commit represents v4.0.0
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
issue-number: ${{github.event.number}}
body: >
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/health-metrics-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 22.10.0
- uses: 'google-github-actions/auth@v0'
# This commit represents v0.8.3
- uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this one is in quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was originally in quotes, didn't want to change it. I think both syntaxes are okay but the quotes are needed if there are special characters or something, so the original author was probably being careful.

with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
- uses: google-github-actions/setup-gcloud@v2
# This commit represents v2.1.4
- uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
- run: yarn install
- run: yarn build
- name: Run health-metrics/binary-size test
Expand All @@ -59,10 +61,12 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 22.10.0
- uses: 'google-github-actions/auth@v0'
# This commit represents v0.8.3
- uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
- uses: google-github-actions/setup-gcloud@v2
# This commit represents v2.1.4
- uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
- run: yarn install
- run: yarn build
- name: Run health-metrics/modular-exports-binary-size test
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/health-metrics-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,14 @@ jobs:
name: Release Diffing
runs-on: ubuntu-latest
steps:
- uses: 'google-github-actions/auth@v0'
# This commit represents v0.8.3
- uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
- uses: google-github-actions/setup-gcloud@v2
- uses: FirebaseExtended/github-actions/health-metrics/release-diffing@master
# This commit represents v2.1.4
- uses: google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a
# This commit represents v1.4
- uses: FirebaseExtended/github-actions/health-metrics/release-diffing@41c787c37157e4c5932b951e531c041efa5bb7a4
with:
repo: ${{ github.repository }}
ref: ${{ github.ref }}
Expand Down
50 changes: 0 additions & 50 deletions .github/workflows/merge-release-branch.yml
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions .github/workflows/release-tweet.yml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/test-changed-firestore-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,17 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- uses: 'google-github-actions/auth@v0'
# This commit represents v0.8.3
- uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72'
if: ${{ fromJSON(env.run_terraform_steps) }}
with:
credentials_json: '${{ secrets.JSSDK_ACTIONS_SA_KEY }}'

# create composite indexes with Terraform
- name: Setup Terraform
if: ${{ fromJSON(env.run_terraform_steps) }}
uses: hashicorp/setup-terraform@v2
# This commit represents v3.1.2
uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
- name: Terraform Init
if: ${{ fromJSON(env.run_terraform_steps) }}
run: |
Expand Down
Loading