-
Notifications
You must be signed in to change notification settings - Fork 943
test(ai): add integration tests #8853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected Products
Test Logs |
packages/vertexai/package.json
Outdated
@@ -39,6 +39,7 @@ | |||
"test:ci": "yarn testsetup && node ../../scripts/run_tests_in_ci.js -s test", | |||
"test:skip-clone": "karma start", | |||
"test:browser": "yarn testsetup && karma start", | |||
"test:integration": "karma start --integration", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to call this from "test" (line 38) if you want to run it on PRs or do you not want to do that yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to add this to test
since then it'll be ran when someone runs test
in the root directory- which is going to fail if someone hasn't defined the config that's used in these tests. Could be annoying for people working on other SDKs
Size Analysis Report 1Affected Products
Test Logs |
346de4e
to
7ad7833
Compare
Vertex AI Mock Responses Check
|
…irebase-js-sdk into dl/vertex-integration
Adds initial setup for integration tests, and integration tests for count tokens, generate content, and chat. Each test runs against both backends (Vertex AI and Google AI), for each specified model in the config.
These tests aim to catch issues that are caused by changes in the backend (e.g. A required field suddenly no longer being sent), and to allow us to confidently support new models by just adding them to the set of models we test against.
Future PRs will integrate this into our CI.
Sample output: