Skip to content

Use base browsers variable in Firestore karma config #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Mar 27, 2025

Firestore's Karma config overwrites the browsers that are set in the base karma config:https://github.com/firebase/firebase-js-sdk/blob/main/packages/firestore/karma.conf.js#L24
getTestBrowsers(argv) only uses the BROWSERS environment variable if it's running the unit tests: https://github.com/firebase/firebase-js-sdk/blob/main/packages/firestore/karma.conf.js#L81
We want the BROWSERS environment to always define the browser to use- regardless of whether we're running unit tests.

@dlarocque dlarocque requested a review from dconeybe March 27, 2025 18:42
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: b9b6aa9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2025

@dlarocque dlarocque marked this pull request as ready for review March 27, 2025 19:23
@dlarocque dlarocque requested review from a team as code owners March 27, 2025 19:23
…Read" which erroneously fails due to different webkit error message on json parse failure compared to chrome
@dconeybe dconeybe merged commit 61f0102 into main Mar 28, 2025
43 of 48 checks passed
@dconeybe dconeybe deleted the dl/fst-karma-browsers branch March 28, 2025 16:24
@firebase firebase locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants