ci: Fix Firefox error and streamline cross-browser tests #9015

hsubox76 · 2025-05-12T20:56:01Z

The main purpose was to fix a Firefox CI test error on one of the util tests - a recent version of Firefox causes the error class to no longer be stored in error.stack and our test that checks for the "FirebaseError" string on a purposefully thrown error now fails. There's no recognizable string in the stack anymore (just code locations), so I just changed it to just check for its existence.

In the course of trying to diagnose this I followed a false trail thinking it might be because Node tests were running during Firefox and Webkit tests. That wasn't the cause but they shouldn't be running during those jobs, it's pointless. Node tests already run during the main Chrome test job. I changed it so that all packages running a cross-browser test use:

"test:browser" if available
special npm script like "test:browser:unit" if specified in the map of special packages (this functionality already existed), to avoid "test:browser:integration" and the like
fall back to "test" if none of those is available

This should make those jobs a little faster and more streamlined.

changeset-bot · 2025-05-12T20:56:05Z

⚠️ No Changeset found

Latest commit: 2ac7821

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-05-12T20:56:13Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

google-oss-bot · 2025-05-12T21:05:38Z

Size Report ¹

Affected Products

@firebase/ai
Type Base (39505cc) Merge (bf124a7) Diff
browser 42.5 kB 42.5 kB +32 B (+0.1%)
main 43.7 kB 43.7 kB +32 B (+0.1%)
module 42.5 kB 42.5 kB +32 B (+0.1%)
@firebase/app-check
Type Base (39505cc) Merge (bf124a7) Diff
browser 26.9 kB 26.9 kB +1 B (+0.0%)
main 27.9 kB 27.9 kB +1 B (+0.0%)
module 26.9 kB 26.9 kB +1 B (+0.0%)
@firebase/auth
Type Base (39505cc) Merge (bf124a7) Diff
browser 193 kB 193 kB -40 B (-0.0%)
module 193 kB 193 kB -40 B (-0.0%)
@firebase/auth/internal
Type Base (39505cc) Merge (bf124a7) Diff
browser 204 kB 204 kB -40 B (-0.0%)
module 204 kB 204 kB -40 B (-0.0%)
@firebase/data-connect
Type Base (39505cc) Merge (bf124a7) Diff
browser 21.7 kB 21.7 kB +63 B (+0.3%)
main 23.9 kB 24.0 kB +47 B (+0.2%)
module 21.7 kB 21.7 kB +63 B (+0.3%)
@firebase/database
Type Base (39505cc) Merge (bf124a7) Diff
browser 250 kB 250 kB -77 B (-0.0%)
main 255 kB 254 kB -82 B (-0.0%)
module 250 kB 250 kB -77 B (-0.0%)
@firebase/database-compat
Type Base (39505cc) Merge (bf124a7) Diff
browser 18.3 kB 18.3 kB +1 B (+0.0%)
main 18.9 kB 18.9 kB +1 B (+0.0%)
module 18.3 kB 18.3 kB +1 B (+0.0%)
@firebase/database-compat/standalone
Type Base (39505cc) Merge (bf124a7) Diff
main 367 kB 366 kB -82 B (-0.0%)
@firebase/firestore
Type Base (39505cc) Merge (bf124a7) Diff
browser 385 kB 385 kB +86 B (+0.0%)
main 596 kB 596 kB -70 B (-0.0%)
module 385 kB 385 kB +86 B (+0.0%)
react-native 385 kB 386 kB +86 B (+0.0%)
@firebase/firestore-lite
Type Base (39505cc) Merge (bf124a7) Diff
browser 114 kB 114 kB -65 B (-0.1%)
main 157 kB 157 kB -70 B (-0.0%)
module 114 kB 114 kB -65 B (-0.1%)
react-native 114 kB 114 kB -65 B (-0.1%)
@firebase/functions
Type Base (39505cc) Merge (bf124a7) Diff
browser 14.2 kB 14.2 kB -40 B (-0.3%)
main 14.8 kB 14.7 kB -45 B (-0.3%)
module 14.2 kB 14.2 kB -40 B (-0.3%)
@firebase/storage
Type Base (39505cc) Merge (bf124a7) Diff
browser 58.5 kB 58.5 kB -37 B (-0.1%)
main 60.1 kB 60.0 kB -42 B (-0.1%)
module 58.5 kB 58.5 kB -37 B (-0.1%)
@firebase/util
Type Base (39505cc) Merge (bf124a7) Diff
browser 29.3 kB 29.3 kB -3 B (-0.0%)
main 35.7 kB 35.7 kB -3 B (-0.0%)
module 29.3 kB 29.3 kB -3 B (-0.0%)

`bundle`

37 size changes

Type	Base (`39505cc`)	Merge (`bf124a7`)	Diff
app-check (CustomProvider)	38.0 kB	38.0 kB	+1 B (+0.0%)
app-check (ReCaptchaEnterpriseProvider)	40.5 kB	40.5 kB	+1 B (+0.0%)
app-check (ReCaptchaV3Provider)	40.5 kB	40.5 kB	+1 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	109 kB	109 kB	-24 B (-0.0%)
database (Append to a list of data)	154 kB	154 kB	-61 B (-0.0%)
database (Filtering data)	153 kB	153 kB	-61 B (-0.0%)
database (Listen for child events)	170 kB	170 kB	-61 B (-0.0%)
database (Listen for value events + Detach listeners)	170 kB	170 kB	-61 B (-0.0%)
database (Listen for value events)	170 kB	170 kB	-61 B (-0.0%)
database (Read data once)	169 kB	169 kB	-61 B (-0.0%)
database (Save data as transactions)	172 kB	172 kB	-61 B (-0.0%)
database (Sort data)	155 kB	155 kB	-61 B (-0.0%)
database (Write data)	154 kB	154 kB	-61 B (-0.0%)
firestore (CSI Auto Indexing Disable and Delete)	280 kB	280 kB	+102 B (+0.0%)
firestore (CSI Auto Indexing Enable)	280 kB	280 kB	+102 B (+0.0%)
firestore (Persistence)	311 kB	311 kB	+102 B (+0.0%)
firestore (Query Cursors)	256 kB	256 kB	+102 B (+0.0%)
firestore (Query)	254 kB	254 kB	+102 B (+0.0%)
firestore (Read data once)	242 kB	242 kB	+102 B (+0.0%)
firestore (Read Write w Persistence)	335 kB	336 kB	+102 B (+0.0%)
firestore (Realtime updates)	244 kB	244 kB	+102 B (+0.0%)
firestore (Transaction)	221 kB	221 kB	+102 B (+0.0%)
firestore (Write data)	220 kB	220 kB	+102 B (+0.0%)
firestore-lite (Query Cursors)	109 kB	109 kB	-49 B (-0.0%)
firestore-lite (Query)	105 kB	105 kB	-49 B (-0.0%)
firestore-lite (Read data once)	80.7 kB	80.6 kB	-49 B (-0.1%)
firestore-lite (Transaction)	106 kB	106 kB	-49 B (-0.0%)
firestore-lite (Write data)	90.3 kB	90.2 kB	-49 B (-0.1%)
functions (call)	39.4 kB	39.4 kB	-24 B (-0.1%)
storage (getBytes)	47.2 kB	47.2 kB	-21 B (-0.0%)
storage (getDownloadURL)	49.3 kB	49.2 kB	-21 B (-0.0%)
storage (getMetadata)	48.7 kB	48.7 kB	-21 B (-0.0%)
storage (list + listAll)	48.1 kB	48.1 kB	-21 B (-0.0%)
storage (updateMetadata)	49.0 kB	49.0 kB	-21 B (-0.0%)
storage (uploadBytes)	53.8 kB	53.8 kB	-21 B (-0.0%)
storage (uploadBytesResumable)	63.8 kB	63.8 kB	-21 B (-0.0%)
storage (uploadString)	54.0 kB	54.0 kB	-21 B (-0.0%)

`firebase`

19 size changes

Type	Base (`39505cc`)	Merge (`bf124a7`)	Diff
firebase-ai.js	33.8 kB	33.8 kB	+12 B (+0.0%)
firebase-app-check-compat.js	23.1 kB	23.1 kB	+1 B (+0.0%)
firebase-app-check.js	25.5 kB	25.5 kB	+1 B (+0.0%)
firebase-auth-compat.js	145 kB	145 kB	-3 B (-0.0%)
firebase-auth-cordova.js	142 kB	142 kB	-2 B (-0.0%)
firebase-auth-web-extension.js	125 kB	125 kB	-2 B (-0.0%)
firebase-auth.js	163 kB	163 kB	-33 B (-0.0%)
firebase-compat.js	802 kB	802 kB	+43 B (+0.0%)
firebase-data-connect.js	18.2 kB	22.7 kB	+4.46 kB (+24.5%)
firebase-database-compat.js	168 kB	168 kB	-60 B (-0.0%)
firebase-database.js	192 kB	192 kB	-80 B (-0.0%)
firebase-firestore-compat.js	347 kB	347 kB	+100 B (+0.0%)
firebase-firestore-lite.js	137 kB	137 kB	-68 B (-0.0%)
firebase-firestore.js	449 kB	449 kB	+83 B (+0.0%)
firebase-functions-compat.js	14.7 kB	14.7 kB	-3 B (-0.0%)
firebase-functions.js	19.5 kB	19.5 kB	-40 B (-0.2%)
firebase-storage-compat.js	44.2 kB	44.2 kB	-2 B (-0.0%)
firebase-storage.js	51.2 kB	51.1 kB	-37 B (-0.1%)
firebase-vertexai.js	33.8 kB	33.8 kB	+12 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/lbEh3huFos.html

google-oss-bot · 2025-05-12T21:18:08Z

Size Analysis Report ¹

This report is too large (255,672 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/NmPqLmBFiE.html

scripts/run_tests_in_ci.js

test firefox error

82a66d2

hsubox76 added 4 commits June 3, 2025 10:26

trigger CI

cd95c9a

run test:browser on all browser tests

401bc2e

try branching logic

8118019

adjust util test

9a50c1e

hsubox76 changed the title ~~test firefox error~~ Fix Firefox error and streamline cross-browser tests Jun 3, 2025

hsubox76 changed the title ~~Fix Firefox error and streamline cross-browser tests~~ ci: Fix Firefox error and streamline cross-browser tests Jun 3, 2025

hsubox76 marked this pull request as ready for review June 4, 2025 17:09

hsubox76 requested a review from a team as a code owner June 4, 2025 17:09

hsubox76 requested review from dlarocque and DellaBitta June 4, 2025 17:09

dlarocque approved these changes Jun 4, 2025

View reviewed changes

scripts/run_tests_in_ci.js Outdated Show resolved Hide resolved

remove extra comment

2ac7821

DellaBitta approved these changes Jun 5, 2025

View reviewed changes

hsubox76 merged commit 6cc9a07 into main Jun 5, 2025
70 of 84 checks passed

hsubox76 deleted the ch-test-firefox-error branch June 5, 2025 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: Fix Firefox error and streamline cross-browser tests #9015

ci: Fix Firefox error and streamline cross-browser tests #9015

Uh oh!

hsubox76 commented May 12, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

google-oss-bot commented May 12, 2025 •

edited

Loading

`@firebase/ai`

`@firebase/app-check`

`@firebase/auth`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented May 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ci: Fix Firefox error and streamline cross-browser tests #9015

ci: Fix Firefox error and streamline cross-browser tests #9015

Uh oh!

Conversation

hsubox76 commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented May 12, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

google-oss-bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/ai

@firebase/app-check

@firebase/auth

@firebase/auth/internal

@firebase/data-connect

@firebase/database

@firebase/database-compat

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/storage

@firebase/util

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsubox76 commented May 12, 2025 •

edited

Loading

changeset-bot bot commented May 12, 2025 •

edited

Loading

google-oss-bot commented May 12, 2025 •

edited

Loading

Size Report ¹

`@firebase/ai`

`@firebase/app-check`

`@firebase/auth`

`@firebase/auth/internal`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented May 12, 2025 •

edited

Loading

Size Analysis Report ¹