Skip to content

Patch MiniJson with a google namespace #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2022
Merged

Patch MiniJson with a google namespace #312

merged 2 commits into from
May 23, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

In the previous build system, the MiniJson library was put into a Google namespace, to prevent overlapping with other usages. This adds that logic back in, by patching the file when it is downloaded.


Testing

Describe how you've tested these changes.

Building locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

#306

@a-maurice a-maurice requested a review from cynthiajoan May 23, 2022 21:47
cynthiajoan
cynthiajoan previously approved these changes May 23, 2022
@a-maurice a-maurice merged commit 7054ec3 into main May 23, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 23, 2022
@github-actions
Copy link

github-actions bot commented May 23, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 7054ec3
Last updated: Mon May 23 19:27 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [2019] [macos] [1/6 Platform(s): iOS] [1/2 Test Device(s): ios_target]
[TEST] [FAILURE] [2019] [macos] [1/6 Platform(s): Android] [1/2 Test Device(s): android_target]
messaging [TEST] [ERROR] [2019] [macos] [2/6 Platform(s): iOS Android] [All 2 Test Device(s)]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/6 Platform(s): Playmode]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2022
@a-maurice a-maurice deleted the am-minijson branch May 24, 2022 17:19
@firebase firebase locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants