Skip to content

Fix MiniJSON namespace in Database #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

Fix MiniJSON namespace in Database #314

merged 1 commit into from
May 24, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Database was using the normal namespace for MiniJSON, so it needs to be updated for the Google one.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from cynthiajoan May 24, 2022 17:22
@a-maurice a-maurice merged commit 80bf31e into main May 24, 2022
@a-maurice a-maurice deleted the am-minijson branch May 24, 2022 17:24
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 24, 2022
@github-actions
Copy link

github-actions bot commented May 24, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @a-maurice on commit 80bf31e
Last updated: Tue May 24 14:18 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): Android] [android_target]
functions [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): windows]
messaging [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Android] [android_target]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2022
@firebase firebase locked and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan