Adds error handling in the signin handler when fetchProvidersForEmail… #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throws some error. This was noticed when the email entered passes client validation but fails on backend validation. In that case, we should display and info bar with the backend error.
channing-google
approved these changes
Apr 4, 2017
wti806
pushed a commit
that referenced
this pull request
Feb 27, 2018
#123) * Adds error handling in the signin handler when fetchProvidersForEmail throws some error. This was noticed when the email entered passes client validation but fails on backend validation. In that case, we should display and info bar with the backend error. * Fixes minor version for closure builder. Latest version is breaking in Travis integration tests. * Revert previous closure builder version change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error handling in the signin handler when fetchProvidersForEmail throws some error.
This was noticed when the email entered passes client validation but fails on backend
validation. In that case, we should display and info bar with the backend error.