Fixes firebaseui.auth.idp.getAuthCredential credential initializer wh… #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich was breaking account linking flow. Added login_hint to Google OAuth flow when the email is specified. This is applied in the following 2 cases: 1. Account linking is triggered and the user needs to sign in to existing Google account. To force the user to sign in to the expected Google account, we pass the login hint with the email. 2. If a user selects email login and the Google account already exists for that email, when clicking continue to sign in with Google account, we pass the login_hint for that account.
channing-google
approved these changes
Apr 5, 2017
| @@ -66,9 +66,18 @@ firebaseui.auth.idp.getAuthCredential = function(credentialObject) { | |||
| if (credentialObject['secret'] && credentialObject['accessToken']) { | |||
| credentialObject['oauthToken'] = credentialObject['accessToken']; | |||
There was a problem hiding this comment.
Do we still need these lines?
There was a problem hiding this comment.
No we don't. I will remove them in my next PR.
wti806
pushed a commit
that referenced
this pull request
Feb 27, 2018
…ich was (#125) breaking account linking flow. Added login_hint to Google OAuth flow when the email is specified. This is applied in the following 2 cases: 1. Account linking is triggered and the user needs to sign in to existing Google account. To force the user to sign in to the expected Google account, we pass the login hint with the email. 2. If a user selects email login and the Google account already exists for that email, when clicking continue to sign in with Google account, we pass the login_hint for that account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebaseui.auth.idp.getAuthCredential credential initializer which was breaking account linking flow.
Added login_hint to Google OAuth flow when the email is specified.
This is applied in the following 2 cases:
To force the user to sign in to the expected Google account, we pass the login hint with the email.
when clicking continue to sign in with Google account, we pass the login_hint for that account.