Skip to content

Fix high severities #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Fix high severities #767

merged 5 commits into from
Oct 15, 2020

Conversation

xil222
Copy link
Contributor

@xil222 xil222 commented Oct 13, 2020

Fix 5 High Severities under following two issues:

  1. https://npmjs.com/advisories/1550 --> "url-regex" all versions have this risk, the recommended way of changing requirement to "url-regex" to "url-regex-safe" wouldn't pass the test.
  2. https://npmjs.com/advisories/1561 --> fix by installing node-forge version 0.10.0 and put that into package-lock.json
    By installing corresponding packages, and edit versions inside package-lock.json.

Since npm install won't install newest versions but just meeting criteria to requirement, running npm install again would change my manual definitions in package-lock.json.

If current solution isn't good enough, I'll try update version for packages on the root(to see if that could raise the requirement of versions for its dependencies)

The root package for node-forge is firebase-tools (not up-to-date)
The root package for url-regex is gulp-concat-css (has been up-to-date)

ps:
I updated firebase-tools to most recent version, somehow the node-forge installed still in version 0.9.2 which has high severities.

I reverted the manual changes in package-lock.json

@bojeil-google bojeil-google merged commit 93bdbc1 into master Oct 15, 2020
@xil222 xil222 deleted the fix-high-severity branch July 29, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants