Skip to content

Release dialog #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Release dialog #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26c0068
use npm ci to replace npm install
xil222 Feb 3, 2021
a807f87
Fixes Chrome bug in dialog auto height which seems to manifest in the…
xil222 Feb 3, 2021
742c318
Merge branch 'master' into releaseDialog
xil222 Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
* Fixes Chrome bug in dialog auto height which seems to manifest in the latest version of Chrome (v88). This seems to not have any side effects on other browsers. Fixes
https://github.com/firebase/firebaseui-web/issues/806

1 change: 1 addition & 0 deletions stylesheet/firebase-ui.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ input.firebaseui-input-invalid{
/* If we do not set height here, the default Safari dialog settings make the
* dialog too tall. */
height: auto;
max-height: fit-content;
padding: 24px;
text-align: left;
}
Expand Down