Skip to content

update dockerversion #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2021
Merged

update dockerversion #861

merged 2 commits into from
Jul 19, 2021

Conversation

xil222
Copy link
Contributor

@xil222 xil222 commented Jul 16, 2021

update dockerversion from 8 to 10

@xil222 xil222 requested a review from bojeil-google July 16, 2021 22:20
@@ -1,4 +1,4 @@
FROM node:8.16.0
FROM node:10.16.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to use Node 14.17.3 (LTS). that is the one recommended for most users.
https://nodejs.org/en/about/releases/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bojeil-google bojeil-google merged commit 6304ef0 into master Jul 19, 2021
@xil222 xil222 deleted the dockerversion branch July 29, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants