Skip to content

docs: firebase_auth description #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Jake-Mok-Nelson
Copy link
Contributor

@Jake-Mok-Nelson Jake-Mok-Nelson commented Jul 17, 2023

Description

Updating the firebase_auth description.

Firebase Auth now also supports web and will probably support more in the future. As a result the Android and IOS mention in the description is out of date.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Firebase Auth now also supports web and will probably support more in the future.
As a result the Android and IOS mention in the description is out of date.
@Jake-Mok-Nelson Jake-Mok-Nelson changed the title Update firebase_auth description docs: firebase_auth description Jul 17, 2023
@Jake-Mok-Nelson Jake-Mok-Nelson marked this pull request as ready for review July 17, 2023 00:12
@Jake-Mok-Nelson
Copy link
Contributor Author

I believe everything has passed except for one check (e2e / ios (packages/cloud_firestore/cloud_firestore/example) (pull_request)), @russellwheatley
I didn't change anything to do with that though so perhaps it was already failing. Will this be merged?

@russellwheatley russellwheatley merged commit d9e0571 into firebase:master Sep 4, 2023
@firebase firebase locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants