-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(firebase_auth): add custom auth domain setter to Firebase Auth #12218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_auth): add custom auth domain setter to Firebase Auth #12218
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hey @Andrey-K-Calven - thanks for the PR! We're discussing internally on how to move this forward, will let you know what results from the discussions 👍 |
Hi, @russellwheatley. Thanks for looking at this, did you have a chance to have that discussion? We'd like to use this approach for our auth domain needs. |
Hey @Andrey-K-Calven, we finally had the green light for this API. Do you mind merging with master to be sure that tests are passing with all the latest changes? |
const PigeonActionCodeSettings* action_code_settings_arg = | ||
nullptr; | ||
if (!encodable_action_code_settings_arg.IsNull()) { | ||
action_code_settings_arg = | ||
&(std::any_cast<const PigeonActionCodeSettings&>( | ||
std::get<CustomEncodableValue>( | ||
encodable_action_code_settings_arg))); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be put back, not related to the modifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another manual update. We should probably make a script for these.
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
…irebase#12218) Co-authored-by: russellwheatley <[email protected]>
Description
#11925 allowed, previously web exclusive, authDomain property to be used on mobile platform; however, actually using it has significant limitations:
[DEFAULT]
FirebaseApp
generated fromGoogleService-Info.plist
/google-services.json
because there's no way to set authDomain via those files.This change addresses those by adding a custom auth domain setter to
FirebaseAuth
, plugging into the existing corresponding setters in the native implementations of FirebaseAuth. With this setter authDomain can be set and reset at will on the[DEFAULT]
FirebaseApp
'sFirebaseAuth
. This allows for custom auth domains to be used with the go-to style ofFirebaseApp
initialisation on mobile platforms and is consistent with the way this is handled in the native implementations.Related Issues
expands on #11925
closes #12517
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?