Skip to content

Cloud function package name #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

Cloud function package name #1250

merged 2 commits into from
Oct 16, 2019

Conversation

blasten
Copy link

@blasten blasten commented Oct 14, 2019

Description

The package name doesn't match the directory structure.

Related Issues

flutter/flutter#42661

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

kroikie
kroikie approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroikie kroikie merged commit dc5fd29 into firebase:master Oct 16, 2019
@blasten blasten deleted the cloud_function_package_name branch October 18, 2019 20:17
@iapicca iapicca mentioned this pull request Nov 1, 2019
Closed
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@kroikie
Cloud function package name (firebase#1250)
d30d7d8 
* [cloud_functions] Fix Android package

* [cloud_functions] Bump version
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@kroikie kroikie kroikie approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blasten @collinjackson @kroikie @googlebot