Skip to content

[firebase_analytics] Support Android v2 embedding #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2019

Conversation

kroikie
Copy link
Collaborator

@kroikie kroikie commented Oct 16, 2019

@kroikie kroikie changed the title Support Android v2 embedding [firebase_analytics] Support Android v2 embedding Oct 16, 2019
@matthew-carroll matthew-carroll self-requested a review October 16, 2019 22:18
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, you might want to try merging master and ensuring that the Firebase Test Lab tests pass.

@kroikie kroikie merged commit d277542 into master Oct 21, 2019
kroikie added a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
* Support Android v2 embedding for firebase_analytics plugin.
@bparrishMines bparrishMines deleted the firebase_analytics_v2_embedding branch April 17, 2020 19:28
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_analytics] Support the v2 Android embedder plugins API
4 participants