Skip to content

Enable Firebase Test Lab testing #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Oct 17, 2019

Updates the FirebaseExtended repo CI to have the same testing on Firebase Test Lab that is used for flutter/plugins.

Eventually I'd like to refactor to eliminate duplicated code, but I'm not sure how to do that.

The only differences between flutter/plugins and FirebaseExtended/flutterfire are the encrypted Firebase Test Lab key, and the all plugins tests.

@collinjackson collinjackson requested a review from amirh October 17, 2019 17:50
@collinjackson collinjackson requested a review from mklim October 18, 2019 00:01
Copy link

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@collinjackson collinjackson merged commit 98c0dab into firebase:master Oct 18, 2019
@collinjackson collinjackson deleted the ftl branch October 18, 2019 20:00
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
* Enable Firebase Test Lab testing
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants