Cast error.code to long to avoid using NSInteger as %ld format warnings. #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@collinjackson could you LGTM this when you get the chance? We are being blocked from rolling this plugin. |
cyanglaz
reviewed
Oct 22, 2019
| @@ -10,7 +10,7 @@ | |||
| static FlutterError *getFlutterError(NSError *error) { | |||
| if (error == nil) return nil; | |||
|
|
|||
| return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %ld", error.code] | |||
| return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %ld", (long)error.code] | |||
There was a problem hiding this comment.
LGTM!
Another way instead of force casting would be always use NSObjects
such as
Suggested change
| return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %ld", (long)error.code] | |
| return [FlutterError errorWithCode:[NSString stringWithFormat:@"Error %@", @(error.code)] |
But I'm ok with whichever you prefer.
There was a problem hiding this comment.
Thanks! Good to know!
cyanglaz
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.