Skip to content

[firebase_core][firebase_analytics] Fix bug with transitive lifecycle dependencies #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 28, 2019

Description

Fixes possible version conflict issues. This would cause runtime class not found errors if any of these plugins relied on Lifecycle at runtime, but they do not.

Test is pending in flutter/plugin_tools#62.

Related Issues

flutter/flutter#43383

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@xster
Copy link
Contributor

xster commented Oct 28, 2019

LGTM

@bparrishMines bparrishMines merged commit 14c97ac into firebase:master Oct 29, 2019
@bparrishMines bparrishMines deleted the compile_only branch October 29, 2019 19:36
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants