Skip to content

[firebase_performance] Fix Pub #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[firebase_performance] Fix Pub #1354

wants to merge 2 commits into from

Conversation

creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Nov 2, 2019

Description

Is there a reason hotfix.5 would be needed? #1353 explains the problem.

Related Issues

Resolves #1353.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@collinjackson
Copy link
Contributor

@mit-mit it seems that pana is using an older stable release of Flutter to analyze plugins. Would it make sense to update it to use the latest stable?

https://pub.dev/packages/firebase_performance#-analysis-tab-

@mit-mit
Copy link
Contributor

mit-mit commented Nov 5, 2019

We just pushed a new release on pub.dev, so it's now using Dart 2.6.0 and Flutter 1.9.1+hotfix.6:
https://pub.dev/packages/firebase_performance#-analysis-tab-

@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_performance] [unidentified]
4 participants