Skip to content

[firebase_crashlytics] Logging improvements #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2019
Merged

[firebase_crashlytics] Logging improvements #1359

merged 7 commits into from
Nov 7, 2019

Conversation

dotdoom
Copy link
Contributor

@dotdoom dotdoom commented Nov 3, 2019

Description

Make logging more obvious and to the right point of verbosity.

This change also gets rid of XCode build warnings about potential security issue with format string.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@dotdoom
Copy link
Contributor Author

dotdoom commented Nov 3, 2019 •
edited
Loading

Since there are now multiple concurrent PRs for firebase_crashlytics, updating pubspec.yaml and/or changelog will be a waste of time (due to version drift).

PTAL and comment whether this change LGTY and once it is, I will make changes to CHANGELOG and pubspec right away.

@dotdoom dotdoom marked this pull request as ready for review November 3, 2019 14:22
@kroikie kroikie self-assigned this Nov 4, 2019
@kroikie
Copy link
Collaborator

kroikie commented Nov 4, 2019

LGTM, feel free to bump version

@dotdoom
Copy link
Contributor Author

dotdoom commented Nov 5, 2019

Done

@dotdoom
Copy link
Contributor Author

dotdoom commented Nov 7, 2019

@kroikie a friendly ping

@collinjackson collinjackson merged commit a09a6df into firebase:master Nov 7, 2019
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@dotdoom @kroikie
[firebase_crashlytics] Logging improvements (firebase#1359)
0b015be 
* Do not add verbose current code location to logs

* Avoid format string injections

* Point out where the logging is coming from
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@kroikie kroikie Awaiting requested review from kroikie

Assignees

@kroikie kroikie

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotdoom @kroikie @collinjackson @googlebot