Skip to content

[firebase_ml_vision] Fix Android e2e test #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 6, 2019
Merged

[firebase_ml_vision] Fix Android e2e test #1363

merged 7 commits into from
Nov 6, 2019

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Nov 4, 2019 •
edited
Loading

Description

This PR skips the e2e on Android. The test fails unless the emulator deletes the data in the Google Play Services app. Issue to track this problem is here #1371

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

bparrishMines
bparrishMines commented Nov 5, 2019
View reviewed changes
packages/firebase_ml_vision/test/firebase_ml_vision_e2e.dart

expect(text.text, 'TEXT');
}, timeout: const Timeout(Duration(minutes: 2)), skip: true);

testWidgets('Is true true?', (WidgetTester tester) async {
Copy link
Contributor Author

@bparrishMines bparrishMines Nov 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firebase Test Lab requires at least one test, so an arbitrary one was added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines merged commit 693c39f into firebase:master Nov 6, 2019
@bparrishMines bparrishMines deleted the ml_fix branch November 6, 2019 00:20
@bparrishMines bparrishMines mentioned this pull request Nov 6, 2019
Merged
13 tasks
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@bparrishMines @kroikie
[firebase_ml_vision] Fix Android e2e test (firebase#1363)
60aaaef
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kroikie kroikie kroikie approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bparrishMines @kroikie @googlebot