Skip to content

Remove @visibleForTesting from FirebaseApp constructor #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2019
Merged

Remove @visibleForTesting from FirebaseApp constructor #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc2a83a
Remove @visibleForTesting from FirebaseApp constructor
kroikie Nov 8, 2019
ca0a817
Add todo for tracking apps
kroikie Nov 8, 2019
90241d6
fix tests
kroikie Nov 8, 2019
c19b0e7
Update packages/firebase_core/lib/src/firebase_app.dart
kroikie Nov 9, 2019
8e9c0c5
Update packages/firebase_core/lib/src/firebase_app.dart
kroikie Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/firebase_core/lib/src/firebase_app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
part of firebase_core;

class FirebaseApp {
@visibleForTesting
const FirebaseApp({@required this.name}) : assert(name != null);
// TODO(jackson): We could assert here that an app with this name was configured previously.
FirebaseApp({@required this.name}) : assert(name != null);

/// The name of this app.
final String name;
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/test/firebase_core_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ void main() {

group('$FirebaseApp', () {
final List<MethodCall> log = <MethodCall>[];
const FirebaseApp testApp = FirebaseApp(
final FirebaseApp testApp = FirebaseApp(
name: 'testApp',
);
const FirebaseOptions testOptions = FirebaseOptions(
Expand Down