Skip to content

[firebase_remote_config] Bumps Android Firebase dependency to 19.0.3 #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 19, 2019
Merged

[firebase_remote_config] Bumps Android Firebase dependency to 19.0.3 #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
545145b
Bump AGP, Gradle & Google Services Plugin
Nov 18, 2019
c101478
Bumps dependency to Firebase Config 19.0.3
Nov 18, 2019
5621f4f
Replaces a deprecated method usage with the updated version
Nov 18, 2019
461a210
Bumps version, adds changelog
Nov 18, 2019
17f71f8
Ensures failed activations set the activateFailed error name
Nov 18, 2019
a904f00
Update CHANGELOG.md
collinjackson Nov 19, 2019
c97708b
Update CHANGELOG.md
collinjackson Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/firebase_remote_config/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.3.0

* Update Android Firebase Remote Config dependency to 19.0.3.
* Resolve an Android compiler warning due to deprecated API usage.
* Bump Gradle, AGP & Google Services plugin versions.

## 0.2.1

* Support Android V2 embedding.
Expand Down
6 changes: 3 additions & 3 deletions packages/firebase_remote_config/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.3.0'
classpath 'com.android.tools.build:gradle:3.5.2'
}
}

Expand All @@ -32,8 +32,8 @@ android {
disable 'InvalidPackage'
}
dependencies {
api 'com.google.firebase:firebase-config:16.4.1'
implementation 'com.google.firebase:firebase-common:16.1.0'
api 'com.google.firebase:firebase-config:19.0.3'
implementation 'com.google.firebase:firebase-common:19.3.0'
implementation 'androidx.annotation:annotation:1.0.0'
}
}
Expand Down
22 changes: 17 additions & 5 deletions ...src/main/java/io/flutter/plugins/firebase/firebaseremoteconfig/MethodCallHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,23 @@ public void onComplete(Task<Void> task) {
}
case "RemoteConfig#activate":
{
boolean newConfig = FirebaseRemoteConfig.getInstance().activateFetched();
Map<String, Object> properties = new HashMap<>();
properties.put("parameters", getConfigParameters());
properties.put("newConfig", newConfig);
result.success(properties);
FirebaseRemoteConfig.getInstance()
.activate()
.addOnCompleteListener(
new OnCompleteListener<Boolean>() {
@Override
public void onComplete(Task<Boolean> task) {
if (!task.isSuccessful()) {
String errorMessage = "Unable to complete activate.";
result.error("activateFailed", errorMessage, null);
} else {
Map<String, Object> properties = new HashMap<>();
properties.put("parameters", getConfigParameters());
properties.put("newConfig", task.getResult());
result.success(properties);
}
}
});
break;
}
case "RemoteConfig#setDefaults":
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_remote_config/example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.3.0'
classpath 'com.google.gms:google-services:4.3.0'
classpath 'com.android.tools.build:gradle:3.5.2'
classpath 'com.google.gms:google-services:4.3.2'
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_remote_config/example/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Fri Jun 23 08:50:38 CEST 2017
#Mon Nov 18 11:38:44 GMT 2019
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
2 changes: 1 addition & 1 deletion packages/firebase_remote_config/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Remote Config. Update your application
re-releasing.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_remote_config
version: 0.2.1
version: 0.3.0

dependencies:
flutter:
Expand Down